Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong facing direction during jump #1113

Closed
Ghabry opened this Issue Mar 4, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@Ghabry
Copy link
Member

Ghabry commented Mar 4, 2017

Movement:

Jump
Right
Right
Down
Land

Attach files (as a .zip archive or link them)

issue1113.zip

Describe the issue in detail and how to reproduce it:

Move on the stairs, press return. The Player faces down during the jump. Expected: Faces Right.

@Albeleon

This comment has been minimized.

Copy link
Member

Albeleon commented Jul 14, 2018

#1401 The Commit "BeginJump calculating the right direction; remove Turn commands inside Jump" solves this and explains the real RPG_RT logic (sum up: Turn doesn't work inside a Jump; the direction is calculated once it knows where it's going to land).

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Jul 15, 2018

These things have high potential to break games if priority or order is wrong. Needs some playtest with problematic games.
Please also have a look here: #1171#1172.

@Albeleon

This comment has been minimized.

Copy link
Member

Albeleon commented Jul 16, 2018

^ The new update has made sure to respect #1171 and #1172 while still solving this issue.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 14, 2018

This is fixed in #1522

@Ghabry Ghabry closed this in 288fffe Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.