New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fast Forward Button not rendered #1124

Closed
BlisterB opened this Issue Mar 13, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@BlisterB
Member

BlisterB commented Mar 13, 2017

Hi everyone :).

The Fast Forward option works like a charmed, really cool!

But the button is not rendered on my Device (Sony Xperia Z3 Compact, API 23), it just displays a rectangle.

@Ghabry if you are bored about this I can fix that with an hard coded shape, I can also add the option to customize the FF button : "press and release" and "press 1 time to active, press 1 time to desactivate".
As you wish, we can also split the two subject :).

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 13, 2017

Member

Meh I added a fallback to show ">" for Api <= 4.0 and hoped this is enough.
Fix it as you wish, I won't work on the Android part anymore.

While working on the settings: Could you also add a slider to adjust speedup level from 2 to 10 (default is 3). I already provided a variable in player.h that can be toggled through JNI to propagate this option to the Player.

Member

Ghabry commented Mar 13, 2017

Meh I added a fallback to show ">" for Api <= 4.0 and hoped this is enough.
Fix it as you wish, I won't work on the Android part anymore.

While working on the settings: Could you also add a slider to adjust speedup level from 2 to 10 (default is 3). I already provided a variable in player.h that can be toggled through JNI to propagate this option to the Player.

@Ghabry Ghabry added the Android label Mar 13, 2017

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Mar 13, 2017

Member
Member

BlisterB commented Mar 13, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 29, 2017

Member

Pokes @BlisterB

The first user asked about a press and release feature ;)

Member

Ghabry commented Mar 29, 2017

Pokes @BlisterB

The first user asked about a press and release feature ;)

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Apr 2, 2017

Member

Yees, it's on my to do list é__è.
I spent some time trying to display the famous ">>" character. I think the problem is that the font used depends on the system and/or version. A fix may be to use a predefined font, i'll work on the subject as soon as I have some time.

Member

BlisterB commented Apr 2, 2017

Yees, it's on my to do list é__è.
I spent some time trying to display the famous ">>" character. I think the problem is that the font used depends on the system and/or version. A fix may be to use a predefined font, i'll work on the subject as soon as I have some time.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Apr 3, 2017

Member

Maybe it makes sense to use a built-in font by google that hopefully exists on any device.
Based on some screenshots custom fonts sometimes break the metrics anyway (letters overlapping with the circles e.g.)

Member

Ghabry commented Apr 3, 2017

Maybe it makes sense to use a built-in font by google that hopefully exists on any device.
Based on some screenshots custom fonts sometimes break the metrics anyway (letters overlapping with the circles e.g.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment