New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opus audio support #1159

Closed
fdelapena opened this Issue May 6, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@fdelapena
Contributor

fdelapena commented May 6, 2017

The Opus codec is currently the state of the art on audio compression, royalty free, and sounds really well on low bitrates, such 48 kbps. This makes this codec perfect for game audio, both for sound effects and music. There are games with large file sizes due to the amount of music and effects bundled with it, and an efficient codec looks a good way to make them significantly smaller. It also has a fixed point implementation.

@fdelapena fdelapena self-assigned this May 6, 2017

@carstene1ns carstene1ns closed this in #1162 Jun 10, 2017

@carstene1ns carstene1ns added this to the 0.5.2 milestone Jun 10, 2017

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Jun 10, 2017

Contributor

It seems there is a bug after trying to restart the song and does not replay it:

Debug: Audio Decoder: Recursion depth exceeded. Probably stream error.
Contributor

fdelapena commented Jun 10, 2017

It seems there is a bug after trying to restart the song and does not replay it:

Debug: Audio Decoder: Recursion depth exceeded. Probably stream error.
@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jun 11, 2017

Member

Well, you are only providing a read replacement with your callbacks. No idea how the library works internally, but I guess it cannot seek backwards this way.


Edit: This is basically said here in the top description: https://www.opus-codec.org/docs/opusfile_api-0.4/group__stream__seeking.html
The seek function will likely return OP_ENOSEEK for us, this could be checked.

Member

carstene1ns commented Jun 11, 2017

Well, you are only providing a read replacement with your callbacks. No idea how the library works internally, but I guess it cannot seek backwards this way.


Edit: This is basically said here in the top description: https://www.opus-codec.org/docs/opusfile_api-0.4/group__stream__seeking.html
The seek function will likely return OP_ENOSEEK for us, this could be checked.

@carstene1ns carstene1ns reopened this Jun 11, 2017

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Jun 11, 2017

Contributor

Right, it tries ten times and fails for all of them with OP_ENOSEEK (-138).

Contributor

fdelapena commented Jun 11, 2017

Right, it tries ten times and fails for all of them with OP_ENOSEEK (-138).

@carstene1ns carstene1ns closed this in #1200 Jun 11, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment