New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7thJojo: Battle against the nurse is unwinnable #1180

Closed
Ghabry opened this Issue May 24, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented May 24, 2017

The patch that fixed "Huntress of the Hollow" #1129 does not fully replicate RPG_RT (of course -_-). Turns out the behaviour is different depending on engine and Ally or enemy.

7thJojo does: Remove Actor 1; Add Actor 2. But the party only has 1 actor so after removing the lose check is True and a GameOver happens.

TestCase: "--battle-test 85 --start-party-id 1". Use "Defend" 3 times.

Expected behaviour:
2k: The victory check happens at the end of the event, so you can freely remove party members and enemies as long as at the end anybody is alive.

2k3: The victory check happens after each line but only for the enemy party. Allies can be removed and added without triggering a lose BUT executing event commands that yield the interpreter (Message, Wait...) while the party is empty crashes the engine with an access violation.

@Ghabry Ghabry added this to the 0.5.2 milestone May 24, 2017

@Ghabry Ghabry self-assigned this May 24, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2017

Only cancel the battle interpreter when a victory condition in RPG2k3…
… happens.

RPG2k and the RPG2k3 lose check (party defeated) can't interrupt the interpreter.

This fixes the battle against the nurse in 7th Jojo.

Fix #1180

carstene1ns added a commit that referenced this issue Jun 23, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Only cancel the battle interpreter when a victory condition in RPG2k3…
… happens.

RPG2k and the RPG2k3 lose check (party defeated) can't interrupt the interpreter.

This fixes the battle against the nurse in 7th Jojo.

Fix #1180

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment