New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM2k battle: Change Enemy HP with Allow Knockout should trigger victory #1191

Closed
rohkea opened this Issue May 28, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@rohkea
Member

rohkea commented May 28, 2017

The Change Enemy HP battle command can trigger victory in RPG Maker 2000, but not in EasyRPG.

Here is a test project (Degica’s RPG_RT, not Don’s, but Don’s should be same):
BattleBug.tar.gz

As can be seen in this project, the EasyRPG ends up with a battle scene with no monsters in it. Trying to do a usual attack on a monsterless battle scene results in an infinite loop.

@rohkea rohkea changed the title from RM2k battle: Change Enemy HP with Allow Knockout can trigger victory to RM2k battle: Change Enemy HP with Allow Knockout should trigger victory May 28, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 28, 2017

Member

Not even downloaded but my educated guess is that your check is on the last event line and the actual bug is here: https://github.com/EasyRPG/Player/blob/master/src/game_interpreter_battle.cpp#L37
This check won't happen for the last executed event line.
(And that behaviour is wrong anyway as stated in #1180)

Member

Ghabry commented May 28, 2017

Not even downloaded but my educated guess is that your check is on the last event line and the actual bug is here: https://github.com/EasyRPG/Player/blob/master/src/game_interpreter_battle.cpp#L37
This check won't happen for the last executed event line.
(And that behaviour is wrong anyway as stated in #1180)

@Ghabry Ghabry added this to the 0.5.2 milestone May 28, 2017

@Ghabry Ghabry self-assigned this May 28, 2017

@rohkea

This comment has been minimized.

Show comment
Hide comment
@rohkea

rohkea May 29, 2017

Member

No, this effect doesn’t depend on the line in which the event command is placed. I’ve just tested with adding more event commands, the battle still doesn’t end.

Member

rohkea commented May 29, 2017

No, this effect doesn’t depend on the line in which the event command is placed. I’ve just tested with adding more event commands, the battle still doesn’t end.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jun 17, 2017

Member

Is this problem exclusive to events that run at the beginning of the battle or does your real game use something different?
Because I can only reproduce it for the "beginning of battle" case.

Member

Ghabry commented Jun 17, 2017

Is this problem exclusive to events that run at the beginning of the battle or does your real game use something different?
Because I can only reproduce it for the "beginning of battle" case.

@rohkea

This comment has been minimized.

Show comment
Hide comment
@rohkea

rohkea Jun 17, 2017

Member

@Ghabry No, it’s not at the beginning of the battle, it’s when hero’s HP ≤30%. Here are the settings I use:
The event I use

(I’ve tried it without ‘Abort Battle’, too. Didn’t work either way.)

Member

rohkea commented Jun 17, 2017

@Ghabry No, it’s not at the beginning of the battle, it’s when hero’s HP ≤30%. Here are the settings I use:
The event I use

(I’ve tried it without ‘Abort Battle’, too. Didn’t work either way.)

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2017

carstene1ns added a commit that referenced this issue Jun 23, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment