New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razas: Incorrect movement frame "left" used instead of "center" #1198

Closed
Ghabry opened this Issue Jun 5, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Jun 5, 2017

Not fixed by my fix for #1112

Name of the game: Razas

You can buy it here for 99ct: https://razas.itch.io/razas

The dev gave us 5 keys a while ago, I'm not sure if all are used yet. I can give you one.

Not tested if the scene is in the public demo

Describe the issue in detail and how to reproduce it:

Start the game with command line "--start-map-id 70 --start-position 20 0"

Just fast-forward enter-smash through the cutscene until the right hero changes from his "star" animation to a standing animation.

In RPG_RT the foot position is centred, in EasyRPG the right food is to the front (not sure if this is left or right stepping through, at least not centered)

@Ghabry

This comment has been minimized.

Member

Ghabry commented Aug 6, 2017

Razas has one event page set to "Step left" but because the Animation type is "standing animation" the step is reset to Middle in RPG_RT but not in Player.

Same behaviour for "Direction Fix/Inanimated"

@carstene1ns carstene1ns modified the milestones: 0.5.4, 0.5.3 Aug 13, 2017

20kdc added a commit to 20kdc/EasyRPG-Player-Dev that referenced this issue Oct 18, 2017

Hopefully fix EasyRPG#1198 by removing original_pattern
original_pattern isn't actually RPG_RT behavior, apparently - the issue 1198 shows this.

I made a testcase, but not much of one.
 I had hoped to check different ways of setting the pattern,
 but apparently walking and page changes are the only things that do it.

So, test this with stuff before considering applying.
Thanks to Ghabry for basically doing most of the work.
The technical description given plus a look through the code showed original_pattern wasn't being honoured, and now I know why.

20kdc added a commit to 20kdc/EasyRPG-Player-Dev that referenced this issue Oct 29, 2017

Hopefully fix EasyRPG#1198 by removing original_pattern
original_pattern isn't actually RPG_RT behavior, apparently - the issue 1198 shows this.

I made a testcase, but not much of one.
 I had hoped to check different ways of setting the pattern,
 but apparently walking and page changes are the only things that do it.

So, test this with stuff before considering applying.
Thanks to Ghabry for basically doing most of the work.
The technical description given plus a look through the code showed original_pattern wasn't being honoured, and now I know why.

carstene1ns added a commit that referenced this issue Oct 29, 2017

Merge pull request #1288 from 20kdc/otherfixes
Various fixes (#1268, #1198, two undocumented GetActors uses, Bitmap::Create(w, h, col). Split from other PR)

@Ghabry Ghabry referenced this issue Dec 7, 2017

Closed

Tileset wrong #1313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment