New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battles randomly(?) show up with wrong backdrop #1224

Closed
Brianum opened this Issue Jul 18, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Brianum
Contributor

Brianum commented Jul 18, 2017

Name of the game: Vampires Dawn 2

Player platform: Windows64

Attach files (as a .zip archive or link them)

  • A savegame next to the problem (if it is not at the beginning of the game)
  • The easyrpg_log.txt log file (you can find it in the game directory)

Before Save&Restart:

[2017-07-19 00:36:52] Debug: Loading Map Map0001.lmu
[2017-07-19 00:36:52] Debug: Tree: Weltkarte
[2017-07-19 00:36:57] Debug: Starting battle 410 (Greifvogel)
[2017-07-19 00:36:57] Debug: Image size out of bounds: Backdrop/001-Grassland01 (320x160 < 320x240 < 320x160)
[...]
[2017-07-19 00:53:08] Debug: Loading Map Map0154.lmu
[2017-07-19 00:53:08] Debug: Tree: Kanalisation < Mesdor < Weltkarte
[2017-07-19 00:53:40] Debug: Starting battle 176 (Blobx2,Kleiner Blob)
[2017-07-19 00:53:40] Debug: Image size out of bounds: Backdrop/001-Grassland01 (320x160 < 320x240 < 320x160)

After Save&Restart, same battle:

[2017-07-19 01:01:51] Debug: Loading Map Map0154.lmu
[2017-07-19 01:01:51] Debug: Tree: Kanalisation < Mesdor < Weltkarte
[2017-07-19 01:02:06] Debug: Starting battle 176 (Blobx2,Kleiner Blob)
[2017-07-19 01:02:06] Debug: Image size out of bounds: Backdrop/dungeon3 (320x160 < 320x240 < 320x160)

Describe the issue in detail and how to reproduce it:

During normal gameplay battles sometimes show up with a wrong backdrop. (The battle seen seems to get stuck with a previous backdrop image) This does not happen in RPG_RT. This happened twice in few hours of plaing, however I was unable to reproduce this. The problem can be worked around by saving the game after this occurs first and restarting the Player, which makes it hard to reproduce, because after starting up the player frehsly and loading the savegame the background continues to work.

@Brianum

This comment has been minimized.

Show comment
Hide comment
@Brianum

Brianum Jul 18, 2017

Contributor

This might be related with random encounters' backdrop. (On the world map in this case)

Contributor

Brianum commented Jul 18, 2017

This might be related with random encounters' backdrop. (On the world map in this case)

@fdelapena fdelapena added the Battle label Jul 18, 2017

@Brianum

This comment has been minimized.

Show comment
Hide comment
@Brianum

Brianum Jul 18, 2017

Contributor

Save05.zip

Reproduction step: Leave village, fight single random encounter, go back to the sewers in town - wrong backdrop.

Contributor

Brianum commented Jul 18, 2017

Save05.zip

Reproduction step: Leave village, fight single random encounter, go back to the sewers in town - wrong backdrop.

@carstene1ns carstene1ns added this to the 0.5.3 milestone Jul 31, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 1, 2017

Member

Thanks for this detailed test case!

Patch:

diff --git a/src/game_battle.cpp b/src/game_battle.cpp
index 78c0c964..56e3c79a 100644
--- a/src/game_battle.cpp
+++ b/src/game_battle.cpp
@@ -88,6 +88,7 @@ void Game_Battle::Quit() {
 	animation.reset();
 
 	Game_Temp::battle_running = false;
+	Game_Temp::battle_background = "";
 
 	std::vector<Game_Battler*> allies;
 	Main_Data::game_party->GetBattlers(allies);
Member

Ghabry commented Oct 1, 2017

Thanks for this detailed test case!

Patch:

diff --git a/src/game_battle.cpp b/src/game_battle.cpp
index 78c0c964..56e3c79a 100644
--- a/src/game_battle.cpp
+++ b/src/game_battle.cpp
@@ -88,6 +88,7 @@ void Game_Battle::Quit() {
 	animation.reset();
 
 	Game_Temp::battle_running = false;
+	Game_Temp::battle_background = "";
 
 	std::vector<Game_Battler*> allies;
 	Main_Data::game_party->GetBattlers(allies);

@Ghabry Ghabry closed this in 7eb998f Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment