New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHR: Wrong CharSet shown in the house eating cutscene #1226

Closed
Ghabry opened this Issue Jul 20, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@Ghabry
Member

Ghabry commented Jul 20, 2017

Please fill in the following fields before submitting an issue:

Name of the game: EHR

Describe the issue in detail and how to reproduce it:

The scene happens shortly after beating the 3 monkeys. 3 scenes later Marin collapses and afterwards the shown eating scene starts.

In the screen the blue woman appars twice. The knight Rod is missing.
2017-07-20-15-09-08

@Ghabry Ghabry changed the title from EHR: Wrong CharSet shown in the house cutscene to EHR: Wrong CharSet shown in the house eating cutscene Jul 20, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 29, 2017

Member

This appears to be caused by the code which fixed the pistole shooting direction in Nobihazard.
The check for this is:

bool last_direction_fixed = old_page && old_page->character_direction != GetSpriteDirection();

Which checks if the position the event looks at changed from the event page default and when it does the next position change is ignored.
Relevant PR: #1020

Member

Ghabry commented Jul 29, 2017

This appears to be caused by the code which fixed the pistole shooting direction in Nobihazard.
The check for this is:

bool last_direction_fixed = old_page && old_page->character_direction != GetSpriteDirection();

Which checks if the position the event looks at changed from the event page default and when it does the next position change is ignored.
Relevant PR: #1020

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jul 30, 2017

Don't apply a direction change when a new event page is executed when…
… the old page and new page direction are the same.

Fix EasyRPG#1226

The patch provided in EasyRPG#1120 was incorrect because it used the current character direction instead of the new page direction.

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jul 30, 2017

Don't apply a direction change when a new event page is executed when…
… the old page and new page direction are the same.

Fix EasyRPG#1226

The patch provided in EasyRPG#1120 was incorrect because it used the current character direction instead of the new page direction.

@Ghabry Ghabry added this to the 0.5.3 milestone Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment