Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Vehicle fails when the Vehicle is entered through EnterVehicle while a move route is active #1267

Closed
Ghabry opened this issue Sep 21, 2017 · 4 comments

Comments

@Ghabry
Copy link
Member

commented Sep 21, 2017

Test case: https://easyrpg.org/play/?game=issue-1267
Press SHIFT, Alex should move into the sky.

The problem is that our "GetOnOffVehicle" checks for "IsMovable" and one case of is movable is: MoveRouteOverwritten. Which is the case in this game.

In RPG_RT the move route actually continues after entering the vehicle.

@Ghabry Ghabry changed the title Enter Vehicle (Airship) fails when the Airship was just moved via "MoveVehicle" on top of the Party and EnterVehicle is called Enter Vehicle fails when the Vehicle is entered through EnterVehicle while a move route is active Sep 21, 2017

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

This can be fixed by removing

if (!IsMovable()))

and replacing it e.g. with

if (!IsStopping())

is stopping checks for !Moving && !Jumping

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

Moving this to next milestone, as this has possibility of breaking things shortly before release.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2019

This is fixed in #1601

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

moved to 0.6.x because 1601 is also 0.6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.