Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k: Unexpected target name when critical hit in Japanese games [regression, bisected] #1291

Closed
kakurasan opened this Issue Oct 22, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@kakurasan
Copy link
Contributor

kakurasan commented Oct 22, 2017

Since 5fba5fb, unexpected target name is inserted before "critical hit" term. (e.g. "[ENEMY_NAME]会心の一撃!!" instead of "会心の一撃!!")

0.5.1:
0.5.1

5fba5fb (0.5.2, unexpected):
5fba5fb
Note that "森の番人トレント" is the name of this enemy.

Returning message instead of GetTarget()->GetName() + message in Game_BattleAlgorithm::AlgorithmBase::GetCriticalHitMessage() works for me.

Note: In GetUndamagedMessage(), GetTarget()->GetName() is needed (There is no need to get rid of GetTarget()->GetName() + here).

@fdelapena fdelapena added the Battle label Oct 22, 2017

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Oct 22, 2017

Thank you for bisecting, seems like this was an oversight.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Oct 22, 2017

Yeah probably %S support was added in 2kE but before it had no actor name at all.

@Ghabry Ghabry added this to the 0.5.4 milestone Oct 22, 2017

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Oct 22, 2017

This is tecnically a regression caused by 0.5.2 but I don't think this is severe enough for a last minute 0.5.3 PR. Thx for the bisect btw 👍

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Oct 22, 2017

It is a simple fix at least, but I also think 0.5.4 is fine.

carstene1ns added a commit that referenced this issue Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.