New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last picture in a savegame is not restored #1299

Closed
Ghabry opened this Issue Oct 29, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Oct 29, 2017

Patch:

diff --git a/src/game_screen.cpp b/src/game_screen.cpp
index 67a8796c..1a390fd1 100644
--- a/src/game_screen.cpp
+++ b/src/game_screen.cpp
@@ -38,7 +38,7 @@ void Game_Screen::CreatePicturesFromSave() {
 
 	pictures.resize(save_pics.size());
 
-	for (int id = 1; id < (int)save_pics.size(); ++id) {
+	for (int id = 1; id <= (int)save_pics.size(); ++id) {
 		if (!save_pics[id - 1].name.empty()) {
 			pictures[id - 1].reset(new Game_Picture(id));
 		}

@Ghabry Ghabry added this to the 0.5.4 milestone Oct 29, 2017

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Oct 29, 2017

hnnng, another off-by-one... :hurtrealbad:

carstene1ns added a commit that referenced this issue Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment