New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VH1 blank screen after using the Portalble Portal given by the Witch #1308

Closed
Mister-Dolus opened this Issue Nov 7, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@Mister-Dolus

Mister-Dolus commented Nov 7, 2017

Please fill in the following fields before submitting an issue:

Name of the game:

Violated Heroine

Player platform:

Linux

Attach files (as a .zip archive or link them)

save.zip
easyrpg_log.txt

Describe the issue in detail and how to reproduce it:

One of the first missions you can take is delivering a package to an old Witch living in the NW woods near a graveyard. After you give her the package, she stops you before you leave and gives you a Portable Portal item. Once you use this item, you are taken to a map where you can choose where to travel. The problem is that once you select a location, all you get is a blank screen and the area never loads.

@KevinX8

This comment has been minimized.

KevinX8 commented Dec 4, 2017

I can also confirm this happens on Android aswell, no matter where you use the portable portal it will always just go to a black screen once you choose a location, the error that appears on screen is "Actor ID 0 is invalid" and this shows up before even choosing a location.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Dec 4, 2017

Download of 170722: https://mega.nz/#F!0ChlQYJa!918hNc-SzjigT-yBqiaidw

Password: Name of the main character in lowercase

@Ghabry

This comment has been minimized.

Member

Ghabry commented Dec 4, 2017

That savegame generates tons of "Removing invalid state: 0" in my sanity check code. Due to how the state array is designed this looks like a bug on my side ^^'

@Ghabry

This comment has been minimized.

Member

Ghabry commented Dec 4, 2017

The problem is the glitter effect (Events 53 & 54) which are parallel processes a run an endless loop using a Label (and Waits 👍) which sets a move route.

Selecting a teleport target invokes page 2 of E51 which does:

SetMoveRoute E53, <empty>
SetMoveRoute E54, <empty>
ProceedWithMovement <-- here it hangs

The ProceedWithMovement hangs endlessly because after the empty move routes are finished one frame later the PPs get there normal move routes again. But empty routes are handled special: They don't introduce a "wait for movement", they finish directly, so after calling these 2 commands the ProceedWithMovement will only wait until the intermediate movement (of the previous route) finishes and then continue.

tl;dr: SetMoveRoute with an empty route is equivalent to the non-existing command: ClearMoveroute

@carstene1ns carstene1ns added this to the 0.5.4 milestone Dec 4, 2017

carstene1ns added a commit that referenced this issue Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment