Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Tear 3: Multiple minor bugs in the battle system #1314

Closed
5 tasks done
Ghabry opened this issue Dec 6, 2017 · 6 comments
Closed
5 tasks done

Final Tear 3: Multiple minor bugs in the battle system #1314

Ghabry opened this issue Dec 6, 2017 · 6 comments

Comments

@Ghabry
Copy link
Member

Ghabry commented Dec 6, 2017

Name of the game: Final Tear 3

https://rpgmaker.net/games/3983/

Attach files (as a .zip archive or link them)

Final Tear 3.zip

Is either Save12 or 13. The correct one is the one in the pyramide.

Describe the issue in detail and how to reproduce it:

Walk upstairs and talk to the chair.
A battle starts.

RPG_RT
screenshot_20171206_221030

EasyRPG
a

  • Wrong background used. Caused by an off-by-one error in the Terrain handing code. Correctly handled in Spriteset_Battle. Can be fixed by removing the else-case in SetupBattle(). 0.6
  • Enemy is placed too far up
  • Battle: Small battle system is not supported #2575
  • The system bar above the FaseSets is missing
  • The bar is transparent
@Ghabry Ghabry added this to the 0.5.4 milestone Dec 6, 2017
@Ghabry Ghabry changed the title Final Tear 3: Wrong battle background used Final Tear 3: Multiple bugs in the battle system Dec 6, 2017
@Ghabry Ghabry changed the title Final Tear 3: Multiple bugs in the battle system Final Tear 3: Multiple minor bugs in the battle system Dec 6, 2017
@Ghabry Ghabry removed this from the 0.5.4 milestone Dec 6, 2017
@Ghabry
Copy link
Member Author

Ghabry commented Nov 7, 2018

Maybe problem 1 and 2 are fixed already, needs testing.

@Ghabry
Copy link
Member Author

Ghabry commented Feb 11, 2019

1 is fixed by #1605
2 is likely depending on bug 1 because this is a terrain option

@fmatthew5876
Copy link
Contributor

It's possible with all the recent battle PRs some more of these got fixed

@fmatthew5876 fmatthew5876 mentioned this issue Oct 13, 2020
91 tasks
@Ghabry
Copy link
Member Author

Ghabry commented Oct 13, 2020

Except for the "small command window" (is one of the battle system types) everything looks correct now:

Screenshot_20201013_231817-fs8

@fdelapena fdelapena added this to the 0.6.3 milestone Oct 23, 2020
@fdelapena fdelapena assigned ghost Mar 19, 2021
@ghost ghost removed their assignment Mar 24, 2021
@ghost
Copy link

ghost commented Mar 24, 2021

Sadly I'm not able to find a clean way to code the small battle window feature. For anyone who feels up to taking on the task, here is the information I gathered about the small window feature:

  • The small windows are only used in RPG Maker 2003 battles
  • The liblcf parameter window_size in the BattleCommands chunk must be set to 1
  • Every window in RPG Maker 2003 battles is displayed small except of the help window and message boxes
  • Small windows have a height of 68 instead of 80 pixels
  • The BorderY value of small windows is 4 instead of 8
  • The content height of small windows is (window_height - 8) instead of (window_height - 16)
  • Menu items in small windows have a height of 14 instead of 16 pixels
  • The SP window in the traditional battle mode has a height of 24 instead of 32 pixels
  • Menus in small windows show only 3 menu items despite the space being sufficient for 4 menu items (like in the normal sized windows)

@Ghabry
Copy link
Member Author

Ghabry commented Jul 12, 2021

moved remaining issue (small window) to new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants