Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel map events "appear to" activate late (Teleport transition issue) #1358

Closed
vgperson opened this Issue May 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@vgperson
Copy link

vgperson commented May 6, 2018

Name of the game:

Witch's Heart (http://vgperson.com/games/witchheart.htm)

Player platform:

Windows

Attach files (as a .zip archive or link them)

WitchsHeartLateParallelBug.zip

Describe the issue in detail and how to reproduce it:

Entering the door in the attached save shows the most noticeable instance of this bug in Witch's Heart. There are parallel events that serve as "covers" for the bathroom area, using Change Event Position to immediately move themselves on top of it. But in EasyRPG, these events do not move into place until after the fade transition is done, so you can easily see the act of "hiding" the bathroom. The issue also comes up more subtly in other places, with parallel map events that set the screen tint seemingly not doing so until after the fade.

The issue is most noticeable when there's a fade-in transition, but even if you set the transition effect to "instant," you can still see a frame where the events have not been repositioned; this also does not happen in RPG_RT.

At first, I thought the parallel events were literally not being activated until the transition was done. However, it seems parallel events that play BGM (like the one that plays Ashe's room music) work just fine, starting before the fade is complete. Thus, I suspect this is actually an issue with transitions themselves. The problems here seem purely visual, so I'm thinking the screen the transition is using is one that has not yet activated parallel events.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented May 6, 2018

Yepp this one is pretty obvious ^^ and interesting because the codeflow is

  1. Scene_Menu::Start which runs parallel events
  2. Transition which renders the screen once and uses this for the transition

Therefore the change should be already part of the transition but isn't

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 6, 2018

Update map spriteset before a transition.
Otherwise parallel events are running for one frame but their visual changes are not visible until the transition is finished.

Won't work properly in emscripten.

Fix EasyRPG#1358

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 6, 2018

Update map spriteset before a transition.
Otherwise parallel events are running for one frame but their visual changes are not visible until the transition is finished.

Won't work properly in emscripten.

Fix EasyRPG#1358

@Ghabry Ghabry added this to the 0.5.4 milestone May 6, 2018

@Ghabry Ghabry modified the milestone: 0.5.4 May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.