Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect text color behavior for choices #1361

Closed
vgperson opened this issue May 7, 2018 · 0 comments

Comments

@vgperson
Copy link

commented May 7, 2018

Name of the game:

Standstill Girl (http://vgperson.com/games/standstillgirl.htm)

Player platform:

Windows

Attach files (as a .zip archive or link them)

StandstillGirlChoiceColor.zip

Describe the issue in detail and how to reproduce it:

Minor but simple: In RPG_RT, text color is not reset between choice options, so color changes can carry over between lines. Choices in Standstill Girl make use of this, only putting a \C[2] in the first option and letting it color all the others too. Walk forward and get to the "Nope / Nope nope" choice for an example.

Window_Message::InsertNewLine() says that choices reset font color, but this seems to be completely false - RPG_RT even has color spill over from the preceding message lines. So that line should just be removed. (Although some extra work is necessary to support the color change for disabled choices.)

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 5, 2019

Tondorian added a commit to Tondorian/Player that referenced this issue Apr 19, 2019

Fix Message Color is reset on multiple choices.
In RPG_RT text color is not reset between selection options, so the player also not do this.

Fix: EasyRPG#1361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.