New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Crystal Hunter: Minigame Kanga Punch has glitchy movement when punching while moving #1413

Closed
Ghabry opened this Issue Sep 3, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@Ghabry
Member

Ghabry commented Sep 3, 2018

Please fill in the following fields before submitting an issue:

Name of the game: Super Crystal Hunter

Not released yet

Describe the issue in detail and how to reproduce it:

Pressing Enter while moving will change the event page to a punch animation with fixed direction and this overwrites the moving direction.

@Ghabry Ghabry added this to the 0.5.4 milestone Sep 3, 2018

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Sep 3, 2018

Don't overwrite the movement direction when the page changes, only th…
…e sprite direction.

Otherwise this causes glitchy movement when an event page switches to an event with a fixed event graphic while a move is being executed.

Fix EasyRPG#1413
@Ghabry

This comment has been minimized.

Member

Ghabry commented Sep 4, 2018

I'm not completely happy with this patch yet, will do some corner case testing (with Move forward)

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Sep 27, 2018

Only change the sprite direction for fixed event graphics, not the mo…
…vement direction when the event page changes.

Otherwise this causes glitchy movement when an event page switches to an event with a fixed event graphic while a move is being executed.

Fix EasyRPG#1413
@Ghabry

This comment has been minimized.

Member

Ghabry commented Sep 28, 2018

removing [Needs feedback] because I'm happy with the new code ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment