New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log.[in]: Wrong event execution order after Erase Screen event #1416

Closed
Ghabry opened this Issue Sep 11, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Sep 11, 2018

Please fill in the following fields before submitting an issue:

Name of the game: https://cachi01.itch.io/login

Describe the issue in detail and how to reproduce it:

Start the game, go to the PC, leave the PC. Start the PC again, screen stays black.

Caused by Event 2 which does on Page 2 (Autorun) a Hide Screen, this results in a yield because we can't have inner loops. After the transition parallel events run and one enables Switch 5 again, which is wrong.

Possible solution: Prevent parallel event execution after returning from a hide/show screen effect, the main event continues without running anything else.

@20kdc

This comment has been minimized.

Contributor

20kdc commented Sep 14, 2018

...It seems like only the interpreter-thread that's responsible for the transition should get priority, no matter which interpreter-thread that is... Maybe allow transitions to have a "responsible interpreter" attached?

@Ghabry

This comment has been minimized.

Member

Ghabry commented Sep 17, 2018

Valid point, just traced parallel events and they behave exactly the same, therefore your suggestion is better.

@Ghabry Ghabry added this to the 0.5.4 milestone Sep 21, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 17, 2018

Ensure that the interpreter that runs after a Erase/ShowScreen is the…
… invoker of the transition.

In RPG_RT transition affects are blocking but we can't do this because of emscripten support.

wait_count was moved down because the wait cycles don't decrement while a transition is executed.

Fix EasyRPG#1416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment