Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Animations (Battle) #1496

Closed
PyredSalsa opened this issue Nov 11, 2018 · 6 comments · Fixed by #2399
Closed

Broken Animations (Battle) #1496

PyredSalsa opened this issue Nov 11, 2018 · 6 comments · Fixed by #2399

Comments

@PyredSalsa
Copy link

Game: Alter A.I.L.A. Genesis

Platform: Windows/Android, ...
Version: v0.5.4 (Nov. 9) / Nightly Build (Nov. 10)

Attached a .gif of the issue, as well as the easyrpg_log.txt. The issue should be universal to every battle in the game, since all the battle animations were broken from the November 9th update onward. Also, I noticed that none of my attacks were showing the amount of damage dealt.

brokenanimation
easyrpg_log.txt

@Ghabry
Copy link
Member

Ghabry commented Nov 11, 2018

Hm, this sounds like a regression. Thanks, for the report.

@PyredSalsa
Copy link
Author

No problem. Just doing my civic duty, I suppose.

@Ghabry Ghabry added the Needs feedback Waiting for the issue author to give further information. label Feb 26, 2019
@Ghabry
Copy link
Member

Ghabry commented Feb 26, 2019

No damage values displaying is not a regression but the broken battle animations are.

I'm not sure if this will be fixed because 0.6 is approaching and I'm currently ordering bugs by priority and this one has very low priority.

As for the 2000 battle system there will be a huge code refactor for the 2003 battle system coming later (for 0.6.1 then) which will hopefully nuke all such bugs forever.

@Ghabry Ghabry self-assigned this Feb 26, 2019
@Ghabry
Copy link
Member

Ghabry commented Feb 28, 2019

The no damage displaying is more complex than expected:
All attacks miss for some reason which makes sense because the base value is 0.
It could be caused by some incorrect event execution, one battle has 52 pages (!).

@Ghabry Ghabry removed the Needs feedback Waiting for the issue author to give further information. label Feb 28, 2019
@Ghabry
Copy link
Member

Ghabry commented Feb 28, 2019

The battle animations are broken due to 97fb076 but imo this commit is correct and the animations don't have the wait-flag set.

Also this is only a visual glitch, not game breaking.

This needs more investigation, postponing.

@Ghabry Ghabry modified the milestones: 0.6.0, 0.6.x Feb 28, 2019
@Ghabry
Copy link
Member

Ghabry commented Jun 7, 2019

still no progress on this one, moving to 0.6.2 as this is 2k3 battle system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants