Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdf2018wildcompodemo: interpreter hangs or skips all map sequences #1517

Closed
fdelapena opened this Issue Dec 2, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@fdelapena
Copy link
Contributor

fdelapena commented Dec 2, 2018

Name of the game:

It does not contain a game title, but the project name on GitHub and in the readme file is tdf2018wildcompodemo.

Player platform:

Any, probably...

Attach files (as a .zip archive or link them)

Not needed

Describe the issue in detail and how to reproduce it:

This amazing demo (live video) has been created by @katai5plate and the scripted full source code (MIT licensed) is available at katai5plate/tdf2018wildcompodemo on GitHub.

It hangs in the first scene after less than 40 seconds at normal speed.
An online version has been uploaded for convenience to the web player: stable, master.

Some few BMPs have been converted to PNG, these have been recompressed with zopfli and MP3 music converted to 24 kbps Opus for faster async download.

Additionally to this hang, player shows a warning instead of a debug message due to the empty title (it could be considered as a bug, as RPG_RT ignores this).

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 2, 2018

guess fixing this will be complete luck as part of a different issue.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 2, 2018

Longer tweet containing more of the tech demo: https://twitter.com/kaiware007/status/1068810114923036672

@fdelapena fdelapena changed the title tdf2018wildcompodemo: interpreter hangs tdf2018wildcompodemo: interpreter hangs or skips all map sequences Dec 3, 2018

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

fdelapena commented Dec 3, 2018

Player behaves different in Emscripten compared with desktop Player. In desktop builds, it teleports between all maps in very few frames, then runs the last sequence and ends the demo. So it seems to be related with timing, as Ghabry points the demo is orchestrated by timers, which helps to keep it on sync with music playback.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 3, 2018

We have a few documented cases where emscripten will behave different but this sound like the first case of a bug where the webplayer executes something different compared to desktop player o.O

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 3, 2018

oh the Tick is really Midi play location. hmmmpf.

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Dec 4, 2018

Implement Get MIDI Ticks for non-MIDI formats by returning the playba…
…ck position in seconds.

Implemented for mpg123, libvorbisfile and libopusfile.
Works for EmptyAudio and SDLAudio by approximating it through the frame count.

When no BGM is playing the returned value is 0.

Fix EasyRPG#1517

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 4, 2018

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

fdelapena commented Dec 4, 2018

@fdelapena fdelapena added the Audio label Dec 4, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 5, 2018

Implement Get MIDI Ticks for non-MIDI formats by returning the playba…
…ck position in seconds.

Implemented for mpg123, libvorbisfile and libopusfile.
Works for EmptyAudio and SDLAudio by approximating it through the frame count.

When no BGM is playing the returned value is 0.

Fix EasyRPG#1517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.