Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper cleanup when returning to the title screen #1524

Closed
3 tasks done
fdelapena opened this issue Dec 5, 2018 · 11 comments
Closed
3 tasks done

Improper cleanup when returning to the title screen #1524

fdelapena opened this issue Dec 5, 2018 · 11 comments
Milestone

Comments

@fdelapena
Copy link
Contributor

fdelapena commented Dec 5, 2018

At least it seems the https://easyrpg.org/play/master/?game=tdf2018wildcompodemo&new-game misbehaves on restart, lacks some stuff, e.g. the first scene and missing the rotating "cube".

@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 12, 2018

Probably load game is broken in similar ways.

We should be using RAII to automatically clean up stuff. Trying to do it by hand is asking for bugs.

@Ghabry
Copy link
Member

Ghabry commented Dec 17, 2018

This could be related to the awful "Game_Temp::restart_title_flag" invented by Sormat whose only purpose is to prevent a Reinitialisation (and BGM restart) when returning from Load to Title via Cancel button.

Maybe the flag is not set to "true" in all code paths.

That whole game-temp-restart-title-junk should be refactored, already hated it when it was added.

@Ghabry
Copy link
Member

Ghabry commented Dec 17, 2018

The problem here isn't the lack of cleanup but that the BGM is not stopped therefore the game reads the wrong value in the first frame of the game. ^^'

@Ghabry
Copy link
Member

Ghabry commented Dec 17, 2018

hm, no, there is also another problem... sorry. Now I see it.

@Ghabry Ghabry added this to the 0.6.0 milestone Feb 12, 2019
@Ghabry
Copy link
Member

Ghabry commented Feb 12, 2019

@fdelapena
Can't find the PR but iirc I fixed this via 8e88e08
Was there anything left?

@fdelapena
Copy link
Contributor Author

Tested with current master and it's still broken but in a different way. Also, when pressing F12 behaves even different.

@Ghabry Ghabry modified the milestones: 0.6.0, 0.6.x Feb 28, 2019
@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.2 May 5, 2019
@Ghabry
Copy link
Member

Ghabry commented Jul 27, 2019

Also broken when Game Over happens as documented here: https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1

I already had multiple times (though randomly) that the title screen graphic does not appear anymore after pressing F12.

Lets take this issue as a catch-all for any bugs related to teardown.

@Ghabry Ghabry changed the title --new-game lacks cleanup after a game starts over by going to the title scene Improper cleanup when returning to the title screen Jul 27, 2019
@fmatthew5876
Copy link
Contributor

#2023 might help with this.

@Ghabry Ghabry modified the milestones: 0.6.2, 0.6.3 Apr 9, 2020
@fdelapena
Copy link
Contributor Author

fdelapena commented Oct 5, 2020

Played tdf2018wildcompodemo in recent master, the demo works flawlessly now after playing the loop 👍

@ghost
Copy link

ghost commented Oct 13, 2020

If you play a RPG Maker 2003 game and the System2 graphics have been set once (which happens if you enter a RPG Maker 2003 battle) and then you exit the game and start an other RPG Maker 2003 game via the browser the System2 graphics from the first game are still used. This leads even to "checkered" graphics if the System2 filename from the first game doesn't exist in the second game.

@fdelapena
Copy link
Contributor Author

Played affected projects, can't reproduce the issues mentioned anymore. #1578 and #2023 and later #2429 for the system2 issue did the trick. No new reports since a while, so let's consider this as fixed, despite still has margin for design improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants