Improper cleanup when returning to the title screen

[fdelapena]

At least it seems the https://easyrpg.org/play/master/?game=tdf2018wildcompodemo&new-game misbehaves on restart, lacks some stuff, e.g. the first scene and missing the rotating "cube".

• Proper cleanup when --new-game is used with F12
• Proper cleanup after Game Over (See https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1)
• Proper cleanup after End Game

[fmatthew5876]

Probably load game is broken in similar ways.

We should be using RAII to automatically clean up stuff. Trying to do it by hand is asking for bugs.

[Ghabry]

This could be related to the awful "Game_Temp::restart_title_flag" invented by Sormat whose only purpose is to prevent a Reinitialisation (and BGM restart) when returning from Load to Title via Cancel button.

Maybe the flag is not set to "true" in all code paths.

That whole game-temp-restart-title-junk should be refactored, already hated it when it was added.

[Ghabry]

The problem here isn't the lack of cleanup but that the BGM is not stopped therefore the game reads the wrong value in the first frame of the game. ^^'

[Ghabry]

hm, no, there is also another problem... sorry. Now I see it.

[Ghabry]

@fdelapena
Can't find the PR but iirc I fixed this via 8e88e08
Was there anything left?

[fdelapena]

Tested with current master and it's still broken but in a different way. Also, when pressing F12 behaves even different.

[Ghabry]

Also broken when Game Over happens as documented here: https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1

I already had multiple times (though randomly) that the title screen graphic does not appear anymore after pressing F12.

Lets take this issue as a catch-all for any bugs related to teardown.