Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper cleanup when returning to the title screen #1524

Open
fdelapena opened this issue Dec 5, 2018 · 7 comments

Comments

@fdelapena
Copy link
Contributor

commented Dec 5, 2018

At least it seems the https://easyrpg.org/play/master/?game=tdf2018wildcompodemo&new-game misbehaves on restart, lacks some stuff, e.g. the first scene and missing the rotating "cube".

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

Probably load game is broken in similar ways.

We should be using RAII to automatically clean up stuff. Trying to do it by hand is asking for bugs.

@Ghabry

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

This could be related to the awful "Game_Temp::restart_title_flag" invented by Sormat whose only purpose is to prevent a Reinitialisation (and BGM restart) when returning from Load to Title via Cancel button.

Maybe the flag is not set to "true" in all code paths.

That whole game-temp-restart-title-junk should be refactored, already hated it when it was added.

@Ghabry

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

The problem here isn't the lack of cleanup but that the BGM is not stopped therefore the game reads the wrong value in the first frame of the game. ^^'

@Ghabry

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

hm, no, there is also another problem... sorry. Now I see it.

@Ghabry Ghabry added this to the 0.6.0 milestone Feb 12, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@fdelapena
Can't find the PR but iirc I fixed this via 8e88e08
Was there anything left?

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Tested with current master and it's still broken but in a different way. Also, when pressing F12 behaves even different.

@Ghabry Ghabry modified the milestones: 0.6.0, 0.6.x Feb 28, 2019

@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.2 May 5, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Also broken when Game Over happens as documented here: https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1

I already had multiple times (though randomly) that the title screen graphic does not appear anymore after pressing F12.

Lets take this issue as a catch-all for any bugs related to teardown.

@Ghabry Ghabry changed the title --new-game lacks cleanup after a game starts over by going to the title scene Improper cleanup when returning to the title screen Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.