Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix remaining CMake issues #1536

Closed
Ghabry opened this Issue Dec 7, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Ghabry
Copy link
Member

Ghabry commented Dec 7, 2018

Player:
Linker error for vcpkg SDL Mixer because Modplug and Flac are not linked which is strange, Find_SDL2Mixer.cmake handles them.

Install PDB files next to the binary.
According to stackoverflow this is possible via
install(FILES $<TARGET_PDB_FILE:${PROJECT_NAME}> DESTINATION bin OPTIONAL)

liblcf: /Ehsc (unwind semantics for exception handling) is not used and emits warnings but don't ask me why there are no warnings when compiling Player...

@Ghabry Ghabry added the Building label Dec 7, 2018

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 7, 2018

@Ghabry Ghabry self-assigned this Dec 7, 2018

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 7, 2018

most likely issue: Modplus and Flac use a macro for __dllexport and I need to define the corresponding macro which removes this from there header files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.