Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine correct screen_shake algorithm #1547

Closed
fmatthew5876 opened this Issue Dec 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 9, 2018

The screen shake algorithm is broken. It has 2 major problems:

  • It stores an extra state variable 'shake_direction' in memory but this is not part of the save data. This makes correct loading not possible
  • The algorithm computes a 0 shake for many common inputs.

I've opened this issue to share data analysis results to figure out what function to use.

I've been using this code in Rpg maker:

Shake Screen: 9, 5, @1.0s
Loop
  Open Save Menu
  Wait: 0.1 seconds

So far, I have this:

RPG_RT+shake(1).pdf

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 9, 2018

Here is a frame by frame breakdown of of some shakes

RPG_RT+Shake+1%2C1+2.0s.pdf
RPG_RT+shake+9%2C1%2C2.0.pdf

With Chery's algo:
RPG_RT-shake_9_1_20.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.