Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic event processing from past map continues if you load a new savefile from event command. #1565

Closed
elsemieni opened this Issue Dec 14, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@elsemieni
Copy link
Member

elsemieni commented Dec 14, 2018

When loading a savefile from command, running events from original map (before load) don't stop processing, cointinuing in the new map in the new "scene".

Player:

Tested in 0.5.4 and Nightly build (to Dec 13th).

Testcase:

An RPG Maker 2003 1.12a project.
https://drive.google.com/file/d/1Uu-TJriFOgJ6wrHViKbze8re3wLqvKjP/view?usp=sharing

The testcase consist in 2 maps and one savefile.
When you start the game, you will start in Map A with an automatic event that makes a beep sound each second until 10 and then it repeats, and a parallel event that wait 3 seconds before calling Load Savefile command.

When you load the savefile, you will end in Map B, with no events at all.

  • In RPG_RT the automatic event will stop instantly.
  • In Player, the automatic event will continue to process, and making beeps each second.
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 14, 2018

Thank you for the bug report, this is great find.

This is another reason we need to move off of globals and use RAII. With automatic cleanup, bugs like this become impossible to write.

@fdelapena fdelapena added the Savegames label Dec 14, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 14, 2018

This bug seems to only affect autostart events.

I tried adding this parallel event:

Tint Red 4.0s Wait
Tint Green 4.0s Wait
Tint Blue 4.0s Wait

After loading the game, the tint commands did not continue.

I changed the sound beep event from Auto start to OnAction and then talked to it with the player. The beeping did not continue.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 14, 2018

The ability of RPG Maker 2k3 to Load anywhere and skip the title scene really caused many problems

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 14, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 14, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 15, 2018

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.