Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pictures won't load when loading savefile in a project with title screen disabled. #1571

Closed
elsemieni opened this Issue Dec 15, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@elsemieni
Copy link
Member

elsemieni commented Dec 15, 2018

When you have a RM2k3 >=1.10 project without Ttitle screen enabled in database, when you try to load a savefile with pictures in game, these won't are being loaded (and didn't shown in screen). However, if you enable Title Screen in Database editor, the images are shown without issue.

Player platform:

Tested in 0.5.4 and Master (Dec 15th).

Test case

Here's a test case:
imgBug.zip

Web: https://easyrpg.org/play/master/?game=issue-1571&engine=rpg2k3e (ignore the missing FaceSets)

A RM2k3 1.12a project with title screen disabled. It goes directly to a almost empty map with a automatic event that shows a dummy image, then it deletes itself, and a helper event for save/load calling.

  • Save the current progress (with debug features or with the helper event).
  • Then load the savefile.

Expected behaviour (RPG_RT 1.12a):

The dummy image is being shown when the map loads.

Current behaviour (Player 0.5.4 , Master):

No image is shown.

Talking with @fdelapena , maybe this bug can be related with #1524

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 15, 2018

This might also explain the missing background in the Razas demo savegame from #1498

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Dec 16, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 17, 2018

And another test case for the web, thx 👍

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 17, 2018

The whole business about a missing title screen is a red herring. This is broken everywhere.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 17, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 18, 2018

Refactor Game_Screen::Reset()
Fixes: EasyRPG#1571

* Call before loading savegame to reset state.
* Don't call after savegame loaded - don't erase pictures or reset state

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Dec 19, 2018

Refactor Game_Screen::Reset()
Fixes: EasyRPG#1571

* Call before loading savegame to reset state.
* Don't call after savegame loaded - don't erase pictures or reset state

@Ghabry Ghabry added Savegames and removed Window/Scenes labels Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.