Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events with Spin restart their animation when write any command and interact with it #1585

Closed
Br4ssman opened this issue Dec 18, 2018 · 3 comments

Comments

@Br4ssman
Copy link

commented Dec 18, 2018

Tested in : Player 0.5.4 (continuous).
How to reproduce it: Create a new event with animation type "Spin" and write any command in it.
Platform: Windows 7 (x64)

Test case:
Restart spin

@Br4ssman Br4ssman changed the title Events with Spin restarts their animation when write any command and interact with it. Events with Spin restarts their animation when write any command and interact with it Dec 18, 2018

@Br4ssman Br4ssman changed the title Events with Spin restarts their animation when write any command and interact with it Events with Spin restart their animation when write any command and interact with it Dec 18, 2018

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 5, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : Fixes EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

This should now be fixed by #1601

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 5, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

@Ghabry Ghabry added this to the 0.6.x milestone Feb 5, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 6, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 6, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 9, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 9, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

@Ghabry Ghabry added the Move Routes label Feb 12, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Feb 16, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 4, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 4, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 4, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 4, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 5, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 6, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk
@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@Br4ssman could you pls confirm that this issue is indeed fixed by https://ci.easyrpg.org/view/Pull%20Requests/job/player-win32-pr/2560/ ?

@fmatthew5876 fmatthew5876 referenced this issue Mar 8, 2019
112 of 113 tasks complete
@Br4ssman

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

@Ghabry It works!

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 10, 2019

Fixes for behaviors when you talk to event
- Spinning events don't change direction : EasyRPG#1585
- Don't reset stop_count or any movement timers when you talk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.