Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakria Legends: Movement hangs on the ramp #1593

Closed
Ghabry opened this issue Dec 23, 2018 · 5 comments

Comments

@Ghabry
Copy link
Member

commented Dec 23, 2018

via Android bug reporting.

Name of the game: Lakria Legends

Yet another REFMAP RPG

Describe the issue in detail and how to reproduce it:

Start with --new-game --start-map-id 18 --start-position 17 5

Walk on the ramp and the game will get stuck in an endless movement uphill/downhill loop.

Quick event analysis:

Start conditions are "event touch"

Top ramp event: (disabled when Going Up = ON)
@> Set Move Route: Player, Turn Right
@> Control Switches: [0032:Going Down] = ON
@> Set Move Route: Player, Move Bottom Right, Move Bottom Right
@> Control Switches: [0032:Going Down] = OFF

Bottom ramp event: (disabled when Going Down = ON)
@> Set Move Route: Player, Turn Left
@> Control Switches: [0031:Going Up] = ON
@> Set Move Route: Player, Move Upper Left, Move Left
@> Control Switches: [0031:Going Up] = OFF

The switch toggling is obviously a red hering, the switch is already OFF again when the movement starts. Can be deleted, result is the same.

Basicly the other ramp event is touched while moving and this triggers the downwards movement.

We already ignore "Player touch" events when a move route is active (matches RPG_RT), maybe the same must be done for "Event touch"? Needs testing. (Changing the events from Event to Player touch fixes it in Player).

Note: Event Touch is CheckCollisionEvent() in Game_Player

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

another good test for #1628 @fmatthew5876

@Ghabry Ghabry added this to the 0.6.x milestone Feb 12, 2019

@Ghabry Ghabry added the Move Routes label Feb 12, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

It is definitely the case that collision trigger does not occur when a move route is active on the player.

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

also fixed by #1601
well that one was simple

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

That is surprising. I expected this one to need trigger changes from #1628

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

hmm indeed. I redownloaded the CI build to be sure. Is indeed 1601 o.O

@fmatthew5876 fmatthew5876 referenced this issue Mar 8, 2019
112 of 113 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.