Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on unhandled empty cancel option in Show Choice command #1634

Closed
fdelapena opened this Issue Feb 12, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@fdelapena
Copy link
Contributor

fdelapena commented Feb 12, 2019

If some game uses an empty option as selected on empty cancel, Player will crash. The following screenshot shows how the cancel key action is mapped to the empty 3rd option:

o

RPG_RT.exe seems to fallback to Cancel and does not display any error, continuing the game as usual.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Feb 12, 2019

we really lack sanity checks all around the interpreter but not worth implementing them everywhere before the magic number code smell is resolved (there was a liblcf issue for thsi, can't findi t)

But this one should be simple to fix.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Mar 4, 2019

I think we catched a common Android crash here 👍

Affected 47 users over the last 60 days.

(is always hard to tell what the real cause is based on the stacktrace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.