Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

もしもスマブラだったら: Actor (Picture) position and zoom incorrect #1662

Closed
Ghabry opened this issue Mar 3, 2019 · 3 comments

Comments

@Ghabry
Copy link
Member

commented Mar 3, 2019

This is a new issue caused by cd4fff9 but based on tests the behaviour in this commit is correct.

The real problem must be somewhere else.
Simply start a battle, you will see the problem - the actors are completely off and not zoomed.

Name of the game: もしもスマブラだったら (https://rmarchiv.tk/games/1412)

Web player: https://easyrpg.org/play/master/?game=smashbros

@Ghabry Ghabry added this to the 0.6.x milestone Mar 3, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

From Cherry's comment in another thread. Here is more about ordering:

Main update methods for common events run (they just check if they are parallel process and the condition is met and then invoke the parallel process worker for them)
Main update methods for map events run (they do a bunch of things, described in my previous post - but actually even more, because after the check for whether there is any active event page, they will run their parallel process worker and then check once more for active)
Message window updates
Timer updates
Screen effects update
Pictures update
Foreground worker runs
Panorama updates

May be related to this

He also says screen effects update after the events (player). So maybe the commit mentioned above is actually wrong. Perhaps its a first frame timing issue?

Will need to re-evaluate this

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

Test Cases 1 - Screen Effects

  1. Setup EV01 as parallel
ShakeScreen Once, 5,,5 @1.0s
OpenSaveMenu
Erase Event
Save shake str shake speed shake pos shake time left
1 5 5 0 60

Result: screen effects don't happen during pre-update

  1. Setup EV01 as parallel
Wait 0.0s
ShakeScreen Once, 5,,5 @1.0s
OpenSaveMenu
Erase Event
Save shake str shake speed shake pos shake time left
1 5 5 3 59

Result: screen effect animates

  1. Setup EV01 as autostart
ShakeScreen Once, 5,,5 @1.0s
OpenSaveMenu
Erase Event
Save shake str shake speed shake pos shake time left
1 5 5 0 60

Result: Screen effect doesn't animate - happens before auto start event

Conclusion

The commit that broke this was wrong. But so was the previous behavior. Screen updates need to happen when Cherry said.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 16, 2019

Fix game screen updating time
Happens after event updates but before foreground worker

Fix EasyRPG#1662
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

Fixed by #1701

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 16, 2019

Fix game screen updating time
Happens after event updates but before foreground worker

Fix EasyRPG#1662

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 17, 2019

Fix game screen updating time
Happens after event updates but before foreground worker

Fix EasyRPG#1662

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 26, 2019

Fix game screen updating time
Happens after event updates but before foreground worker

Fix EasyRPG#1662

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 31, 2019

Fix game screen updating time
Happens after event updates but before foreground worker

Fix EasyRPG#1662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.