Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading RPG_RT savegames triggers screen shake #1668

Closed
fdelapena opened this issue Mar 5, 2019 · 17 comments · Fixed by #1922
Closed

Loading RPG_RT savegames triggers screen shake #1668

fdelapena opened this issue Mar 5, 2019 · 17 comments · Fixed by #1922

Comments

@fdelapena
Copy link
Contributor

@fdelapena fdelapena commented Mar 5, 2019

Hi, I'm having some troubles after the last update. Now some of the games I was playing, like Yume Nikki, don't stop shaking after I load the save file.

Yume Nikki easyrpg_log.txt
Yume Nikki savegames

OFF translation 2.0 easyrpg_log.txt
OFF translation 2.0 savegames

@fdelapena fdelapena added the Savegames label Mar 5, 2019
@fdelapena fdelapena added this to the 0.6.1 milestone Mar 5, 2019
@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Mar 5, 2019

The chunks say:

    <shake_continuous>T</shake_continuous>
    <shake_strength>1</shake_strength>
    <shake_speed>9</shake_speed>
@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Mar 5, 2019

hard to say where the problem is because my old savegames don't shake in YN

@carstene1ns

This comment has been minimized.

Copy link
Member

@carstene1ns carstene1ns commented Mar 5, 2019

I just built Player@e410c9c with EasyRPG/liblcf@5b52d85 to recreate the issue and it does not happen. Also, when re-saving the shake is gone...

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Mar 5, 2019

If it has the shake_continuous chunk as 1 then the game will shake...

Not sure how it got that chunk but if it's there then it's doing what it is supposed to do.

@fdelapena fdelapena changed the title Yume Nikki: permanent screen shake on legacy savegame loading Loading RPG_RT savegames triggers screen shake Mar 7, 2019
@fdelapena

This comment has been minimized.

Copy link
Contributor Author

@fdelapena fdelapena commented Mar 7, 2019

Savegames are created in PC with RPG_RT.exe, confirmed by the reporter.

Added OFF translation 2.0 savegames and log.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Apr 11, 2019

Are we absolutely sure the reporter created the save game with RPG_RT and not player?

If the save game was really created by Player, then I'd bet this was the same as #1743. The save game has the continuous chunk set to true, and if there was no continuous shake in the event code.. Then I don't know what else to say..

@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Apr 11, 2019

Well assuming the EasyRPG version used to play on the PC is old enough (0.5.4, not a nightly) then we could proof if it is a EasyRPG or RPG_RT save by simply saving-and-loading it through some lcf2lcf tool because of the way how chunks were written in 0.5.4.

@carstene1ns

This comment has been minimized.

Copy link
Member

@carstene1ns carstene1ns commented Apr 11, 2019

But this might be affected by EasyRPG/liblcf#305.

@fdelapena fdelapena modified the milestones: 0.6.1, 0.6.2 Jul 1, 2019
@Ghabry Ghabry modified the milestones: 0.6.2, 0.6.1 Jul 14, 2019
@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Jul 20, 2019

Considering that we never got another bug report about this even though this made popular games unplayable I consider this bogus and close it without further investigation.

Maybe fixed by #1743

@Ghabry Ghabry closed this Jul 20, 2019
@Ghabry Ghabry removed the Needs feedback label Jul 20, 2019
@Nootboot64

This comment has been minimized.

Copy link

@Nootboot64 Nootboot64 commented Oct 21, 2019

I get that too! Sorry for taking so long to find this, but on my PSVITA, I get infinite screen shake after loading my save file, specifically when I had transferred it from my PC. I get this on OFF, but it is the only game I've tested. I'm using the latest version too, I think.

@carstene1ns

This comment has been minimized.

Copy link
Member

@carstene1ns carstene1ns commented Oct 21, 2019

Please send us the savegame (saved by RPG_RT).

@carstene1ns carstene1ns reopened this Oct 21, 2019
@carstene1ns carstene1ns modified the milestones: 0.6.1, 0.6.2 Oct 21, 2019
@Nootboot64

This comment has been minimized.

Copy link

@Nootboot64 Nootboot64 commented Oct 21, 2019

Here, I think this is what you meant:
Save01.zip

@Ghabry Ghabry removed the Needs feedback label Oct 22, 2019
@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Oct 22, 2019

Shame, so we actually didn't fix it? :/

A second savegame is available here: https://community.easyrpg.org/t/saves-imported-that-are-not-initially-made-in-easyrpg-causing-screen-shaking/755

@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Oct 27, 2019

Okay this is interesting.
When I load the attached Save01.zip by Nootboot in OFF it shakes in Player but not in RPG_RT. shake_continious is T. Maybe there is a second variable required in the savefile to really start a shake?

@Ghabry

This comment has been minimized.

Copy link
Member

@Ghabry Ghabry commented Oct 27, 2019

Found it already. >.>
When you call "Start shake" it sets shake_continuous to T and shake_time_left to 65535. The time is decrementing each frame and when it reaches 0 (confirmed with save editing by changing it to 100) the shake stops when it is at 0 (!)

And when you call "Shake: Stop" continious stays on T and time left becomes 0

The only command that resets continuous to F is "Shake: Once".

(Attention: Permanent shake is a 2k3 feature, don't load it in 2k :) )

@Nootboot64

This comment has been minimized.

Copy link

@Nootboot64 Nootboot64 commented Oct 28, 2019

So until there's a permanent fix, couldn't I just get the save with the edits and use that?

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 29, 2019
* Stoping shake doesn't clear the flag
* Flag is ignored if time == 0

Fix EasyRPG#1668
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Oct 29, 2019

Fixed in #1922

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 29, 2019
* Stoping shake doesn't clear the flag
* Flag is ignored if time == 0

Fix EasyRPG#1668
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 30, 2019
* Stoping shake doesn't clear the flag
* Flag is ignored if time == 0

Fix EasyRPG#1668
@Ghabry Ghabry closed this in #1922 Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.