Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player should not display warnings on missing audio RTP files #1672

Closed
fdelapena opened this issue Mar 6, 2019 · 10 comments

Comments

@fdelapena
Copy link
Contributor

commented Mar 6, 2019

I suggested this as part of a review comment in #1630. It seemed to be fixed, but the issue persists and we got a couple of email reports because there are broken games. Game devs don't detect this quite often because RPG_RT does not complain and silently ignores them, so they should go to debug output to match the behavior.

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

The part where we disabled the Warning is:
The game uses FullPackageFlag and RTP sounds are missing.

In the other cases this is now by design because we got bug reports that Sounds are not playing.

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

There are also two reports in the Yume Nikki Discord because of Warnings in Yume2kki and they can't fix them because they don't have a Computer...
I think for 0.6.1 we have to reevaluate who is worse, the ones complaining about missing sounds or the ones about the RTP warning.

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

We could just extend the check to exclude sounds in general.
However, this would hide game bugs.

The other bug report mail (Eternal Legends) is probably related to converted wave files (or, the warning is real and the RTP was not installed correctly https://youtu.be/cphNpqKpKc4)

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Just as a note, this covers Sound and Music folders

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

There are also two reports in the Yume Nikki Discord because of Warnings in Yume2kki

Would be interesting to know, which warning was triggered there.

Yume2kki is at least problematic, since there are many different authors and likely nobody knows who introduces such bugs (also the manipulated path issue we had before).

@carstene1ns carstene1ns added this to the 0.6.1 milestone Mar 7, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

no jp keyboard here written in romaji: The missing file is "Sound/gashan" (glass).
Happens directly in Urotsukis main room.

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

A mixed, dirty provisional solution proposal: silence RTP audio warnings just for system database sounds (and from them, those changed later in-game) because they are used a lot and fill the console.

Maybe it's time to slowly consider bundling some common system audio files with proper license from freesounds and opengameart (and bundle the Object CharSet for the door in Nobihaza ;) ).

@fdelapena fdelapena added the UX label Apr 18, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Well now that we finally have good installers for 2k and 2k3 RTP we could create another app which downloads and installs the RTP on Android ;)

@fdelapena

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Worked around at 45ce920

@Ghabry

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

fixed by #1754

@Ghabry Ghabry closed this Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.