Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Battle Shake #1678

Closed
fmatthew5876 opened this issue Mar 9, 2019 · 2 comments

Comments

@fmatthew5876
Copy link
Contributor

commented Mar 9, 2019

In battle 2k, the screen shakes when the player takes damage.

  • Verify our shake is accurate

In Player we do ShakeOnce(5 power, 5 speed, 6 frames). I have no idea if this is accurate. @CherryDT how can we verify the correct shake parameters used for this?

  • Verify how this shake interacts with map shake

We use the same function as map shake, which could end up canceling map shake.

Run some experiments by triggering battles with an active shake on the map, figure out what RPG_RT does, and emulate it properly.

@CherryDT

This comment has been minimized.

Copy link

commented Mar 9, 2019

I think it was 3,5,8
And there is only one shake, so I think it overrides the map shake, although I don't know how it interacts with continuous shake in 2k3 obviously not at all, since 2k3 doesn't shake on damage, doh

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

I checked RPG_RT and player with a long shake followed by a battle.

The shake continues in the battle. Once an enemy hits the player, the enemy shake cancels the long shake. So we're compatible on this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.