Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Above tile events should be drawn below non-above tile events #1683

Closed
fmatthew5876 opened this issue Mar 10, 2019 · 7 comments

Comments

@fmatthew5876
Copy link
Contributor

commented Mar 10, 2019

Issue summary:

  • Draw order of above and non-above tile events is wrong
  • Airship and shadow are drawn under above events while flying

Create EV01 as layer=below with a passable but not above tile graphic.
Create EV02 as layer=below with an above tile graphic (passable or not)

Setup another event to place EV01 and EV02 on the same tile.

In RPG_RT, EV01 is drawn ontop of EV02
In Player, EV02 is drawn ontop of EV01

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

What is a above tile? Do you mean star tile?
Does the same happen when 1 and 2 are swapped?

2k3e made some changes to make the render order of events more consistent. When there is sth rendering related Also check with older 2k3 versions if the result is consient or random.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

I mean star tiles.

I tested this with rm2ke.

Its broken the other way too.
If EV01 is above tile and EV02 is not

RPG_RT shows EV01 above EV02
Player shows EV02 above EV01

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

There are also graphical glitches with the airship.

In Player, events with layer=above are rendered overtop of the airship and its shadow while it is flying.

For the airship case, probably we just need to check IsFlying() and bump the draw layer above all events if so.

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 11, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

#1577 could be related

@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.2 May 5, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Test Cases 1 - Normal Cases

Setup EV01 and EV02 to be placed ontop of each other

The following cases have the resulting rendering in RPG_RT:

EV01 EV02
Sprite Sprite
Below Tile Below Tile
Sprite Below Tile
Below Tile Sprite
Star Tile Sprite
Sprite Star Tile
Star Tile Star Tile
Below Tile Star Tile
Star Tile Below Tile
EV01 layer EV02 layer top
below below EV02
below same EV02
below above EV02
same below EV01
same same EV02
same above EV02
above below EV01
above same EV01
above above EV02
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Now I can't reproduce the tile issues I saw before.. Maybe I made some mistake?

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 26, 2019

For 2 events on the same position with same layer the order is undefined, in RPG2k3E it is based on the event ID.

@carstene1ns carstene1ns modified the milestones: 0.6.2, 0.6.1 May 26, 2019

@Ghabry Ghabry closed this in #1775 May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.