Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ Legend of Z: Charge UP percentage skill cost #1684

Closed
OmegaMagnusDA opened this issue Mar 10, 2019 · 2 comments

Comments

@OmegaMagnusDA
Copy link

commented Mar 10, 2019

Name of the game: Dragon Ball Z: Legend of Z RPG

Player platform: Android and possibly others

-Download DBZ LOZ (No music version) for quickest download (third option) https://gamejolt.com/games/dragon-ball-z-legend-of-z-rpg/145494

-Save(s): https://drive.google.com/open?id=1zb7NObjqhmKu_hjwl-TZ45SeExRvO2la (see skill in menu and/or roam around current map to test in battle)
https://drive.google.com/open?id=1nnymRrmyPsXMfICy5NARPjVZQsACRH-o (save with higher party levels)

-easyrpg_log.txt log file: https://drive.google.com/open?id=1O7Hr7P-puoby0-YWZQHLB1pKCR2AKyHJ

Issue in detail and how to reproduce it:
Issue from #1374 is half fixed. Charge UP now gives players the right amount of KI (MP), in recent update 0.6, but the skill cost is still stuck at 1 for all characters at all levels (percentage skill costs).

image

@fdelapena fdelapena added the Battle label Mar 11, 2019

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 11, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

This is caused by this bad line of code:
https://github.com/EasyRPG/Player/blob/master/src/game_battler.cpp#L424

It should be Player::IsRPG2k3() and not checking a specific version.

I have a different idea for a fix however..

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Hmm, this has been in there since 2011, way before we had different engine modes (2k3e did not exist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.