Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ Legend of Z: 1 HP at beginning of battle despite event command requesting full heal before battle #1685

Closed
OmegaMagnusDA opened this issue Mar 10, 2019 · 4 comments

Comments

@OmegaMagnusDA
Copy link

commented Mar 10, 2019

Name of the game: Dragon Ball Z: Legend of Z RPG

Player platform: Android and possibly others

-Download DBZ LOZ (No music version) for quickest download (third option) https://gamejolt.com/games/dragon-ball-z-legend-of-z-rpg/145494

-Save(s): https://drive.google.com/open?id=11MZSXtwmaNd-dBA-t488XCxxSf8qeIgG (enter house to the right and go through quick dialogue scenes to the battle, Goku vs Raditz at Roshi House)

-easyrpg_log.txt log file: https://drive.google.com/open?id=1O7Hr7P-puoby0-YWZQHLB1pKCR2AKyHJ

Issue in detail:
New error from 0.6. Before Goku engages in battle with Raditz, he has 1 HP even though there is a event command that requests full heal. The event commands on this map have not been changed before or after the release of 0.6.
The commands are as listed below. It looks like the "-9999 HP" is being done before battle when its listed to be executed after battle. The 2nd picture are the battle events of the battle that are supposed to happen but since the party member is at 1 HP, gameover results when Raditz attacks.

Event Editor:
image

Battle Events (from Monster Group/Troops):
image

@OmegaMagnusDA OmegaMagnusDA changed the title DBZ Legend of Z: 1 HP at beginning of battle despite event commands requesting full heal beforehand DBZ Legend of Z: 1 HP at beginning of battle despite event commands requesting full heal before battle Mar 10, 2019

@OmegaMagnusDA OmegaMagnusDA changed the title DBZ Legend of Z: 1 HP at beginning of battle despite event commands requesting full heal before battle DBZ Legend of Z: 1 HP at beginning of battle despite event command requesting full heal before battle Mar 10, 2019

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 11, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Wow this one is super interesting.

If you do this code:

Battle
Change HP -9999

It works correctly

But if you do

Message: Hi
Battle
Change HP -9999

The battle starts with 1 HP!

So something about the the message really messes things up!

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

This is even more broken. If you change the above event to autostart, it just keeps showing "Hi" message box over and over, never starting the battle...

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@CherryDT

Maybe you could help us with a little insight on how game message event commands work?

When a message is started what chunks get set?
What is the behavior for blocking other events execution exactly?
Any frame delays?
Any other wierd edge cases?

I can't really test this one with my save method unfortunately. Only before the message appears and after it's gone.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 17, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

DBZ issue fixed by #1705

The bug was that the autostart event would set the scene call value while the message was closing but still visible, but then Scene_Map doesn't change scenes because Game_Message::visible is still true. Then the update routine runs again and events update again, processing the ChangeHP command.

Proper message test cases and refactoring will be done later.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 17, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.