Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game_Character::GetScreenX() and Y are wrong on looping maps #1699

Closed
fmatthew5876 opened this issue Mar 15, 2019 · 1 comment

Comments

@fmatthew5876
Copy link
Contributor

commented Mar 15, 2019

On a looping map, the event commands that retrieve an events x and y screen coordinates into a variable return the wrong values in player.

Here are what they should be in the edge

Local (screen) Tile position Screen pos
x=0 x=8
x=-1 x=-8
x=-2 x = (map_width - 1) * 16 + 8
y = 0 y = 16
y = -1 y = 0
y = -2 y = (map_height - 1) * 16

This also affects move towards / away from player in #1698

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

Here's another RPG_RT bug related to this.

Play a large battle animation on an event x=-2 tiles off the screen. If the screen is non-looping, you'll see the edge of the animation. If the screen is looping, you won't see it. ❗️

If x=-1, you see the animation in both cases as the screen x hasn't wrapped yet.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 16, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 16, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 16, 2019

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 16, 2019

@Ghabry Ghabry closed this in #1700 Mar 23, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.