Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoramas are not frame accurate #1704

Closed
fmatthew5876 opened this issue Mar 16, 2019 · 2 comments

Comments

@fmatthew5876
Copy link
Contributor

commented Mar 16, 2019

Panorama update should happen at the very end of Game_Map::Update() routine and should not happen during pre update.

Currently, player does this at the beginning of the frame.

Main update methods for common events run (they just check if they are parallel process and the condition is met and then invoke the parallel process worker for them)
Main update methods for map events run (they do a bunch of things, described in my previous post - but actually even more, because after the check for whether there is any active event page, they will run their parallel process worker and then check once more for active)
Message window updates
Timer updates
Screen effects update
Pictures update
Foreground worker runs
Panorama updates

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 17, 2019

@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.2 May 5, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Test Cases 1 - Scrolling

  1. Create a 20x15 map with Galaxy picture, auto scroll both directions speed 1

Setup Ev01 parallel:

Loop:
  OpenSaveMenu
Save pan_x pan_y
1 0 0
2 20478 15358
3 20476 15356

Conclusion

Parallax doesn't update during pre-update.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Test Cases 2 - Moving

  1. Map 80x80
    Panorama: Galaxy - no scrolling or looping
    Player Start: (20,15)
    EV01 parallel:
SetMoveRoute: Player, Step Right
Loop:
  OpenSaveMenu
Save pan x pan y
1 1877 945
2 1898 945
3 1920 945
  1. Now change panorama to loop horizontall, no scroll
Save pan x pan y
1 2816 945
2 2848 945
3 2880 945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.