Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files not listed in the RTP replacement tables are not found #1709

Closed
fdelapena opened this issue Mar 17, 2019 · 2 comments

Comments

@fdelapena
Copy link
Contributor

commented Mar 17, 2019

This issue affects modified or unknown RTPs, e.g. games using Don's RTP extras (there are quite a few) and Don's RTP 1.32.

How to reproduce:

Add some file to the RTP with a custom name not in RTP tables, then use this asset from a game.

A simpler way to reproduce this is by installing Don's RTP and run run Don's Adventures game.

Possibly related with #1630.

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 17, 2019

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Yes, before we still searched through the RTP folder for unknown files. A proper fix is more complicated, but a quick solution is to move the for loop back out of the rtp_name check here:

Player/src/filefinder.cpp

Lines 214 to 233 in 85a40f0

if (!rtp_name.empty()) {
// RPG_RT will even load RTP files when the game disables it
if (disable_rtp_warnings && !warning_broken_rtp_game_shown) {
std::string lcase = Utils::LowerCase(dir);
if (lcase != "music" && lcase != "sound") {
warning_broken_rtp_game_shown = true;
Output::Warning("This game claims it does not need the RTP, but actually uses files from it!");
}
}
for(search_path_list::const_iterator i = search_paths.begin(); i != search_paths.end(); ++i) {
if (! *i) { continue; }
std::string const ret = FindFile(*(*i), dir, name, exts);
if (!ret.empty()) { return ret; }
std::string const ret_rtp = FindFile(*(*i), dir, rtp_name, exts);
if (!ret_rtp.empty()) { return ret_rtp; }
}
}

Issue originally reported by @rohkea in IRC.

@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

yeah this was not intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.