Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k3: Weapons don't invoke skills #1722

Closed
s9060666 opened this issue Mar 22, 2019 · 14 comments

Comments

@s9060666
Copy link

commented Mar 22, 2019

Thank you for supporting EasyRPG Player.
Before creating an issue, please verify that your bug still occurs in the "continuous builds" of the Player.
You can get them at the bottom of our download section: https://easyrpg.org/player/downloads


Please fill in the following fields before submitting an issue:

Name of the game:月藍傳奇1

Player platform:Android

Windows, Linux, Android, ...

Attach files (as a .zip archive or link them)

  • A savegame next to the problem (if it is not at the beginning of the game)
  • The easyrpg_log.txt log file (you can find it in the game directory)

Describe the issue in detail and how to reproduce it:

Use item:白虎杖
Normal use magic:狂風IV
After using the item, nothing happens. Calculate the round directly.

@fdelapena fdelapena added the Battle label Mar 23, 2019

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 23, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

@Ghabry Ghabry changed the title Invalid use of the item Battle 2k3: Weapons don't invoke skills May 25, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

This is basicly "Weapons that invoke skills (When you use them as an item) don't work"

@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.2 May 25, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Weapons invoking skills is already fixed in master

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

doesn't work for me

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Ok I'll have to check this one out. I tested a weapon which invokes healing magic in a test game and it worked. I didn't test this game specifically.

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

I also didn't test the game, as I couldn't find the item ^^'.

I used a test game and just changed Club to do Poison.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Ok I'm really confused now.

pswd

This works for me. I can use the item and do poison attack. I also tried to change poison attack to not do damage and only inflict poison, still works.

How is yours different?

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

I found the problem.
It only fails when the item is not in the inventory but only equipped (when equipped and has a skill it will still appear in the item list as x1 for this actor)

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

Ok, so I did that. Equipped my "POISON SWD". The actor with it equipped can use it, the other actor it doesn't appear.

So still I say it works for me!

What else is different in your case?

@s9060666

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@s9060666

Do you have a save game with the item that I can use to reproduce the bug?

@s9060666

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@fmatthew5876
https://drive.google.com/file/d/1-Eb7b-keD--B39zzV3JUwO-T1LzvHOGR/view?usp=drivesdk
You can try this archive
Pick a character in battle:風鈴鈴->物品->白虎杖

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

I can reproduce this.

The weapon is usable in the inventory from the 2nd actor. It is weapon 179 which invokes skill 145. The skill when invoked does nothing.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 6, 2019

Battle: SkillItem use - check equipped
If an actor uses an equipment which invokes a skill and the only
one we have is equipped to the actor, this check would fail and
cause the skill to do nothing.

Fix: EasyRPG#1722
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Fixed by #1797

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 6, 2019

Battle: SkillItem use - check inventory + equipped
If an actor uses an equipment which invokes a skill and the only
one we have is equipped to the actor, this check would fail and
cause the skill to do nothing.

Fix: EasyRPG#1722

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 6, 2019

Battle: SkillItem use - check inventory + equipped
If an actor uses an equipment which invokes a skill and the only
one we have is equipped to the actor, this check would fail and
cause the skill to do nothing.

Fix: EasyRPG#1722
@fmatthew5876 fmatthew5876 referenced this issue Jun 6, 2019
0 of 3 tasks complete

@Ghabry Ghabry modified the milestones: 0.6.2, 0.6.1 Jun 6, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 6, 2019

Battle: SkillItem use - check inventory + equipped
If an actor uses an equipment which invokes a skill and the only
one we have is equipped to the actor, this check would fail and
cause the skill to do nothing.

Fix: EasyRPG#1722

@Ghabry Ghabry closed this in #1797 Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.