Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title scene background should be black if title graphic is undefined in RPG_RT.ldb #1728

Closed
fdelapena opened this issue Mar 26, 2019 · 0 comments

Comments

@fdelapena
Copy link
Contributor

commented Mar 26, 2019

Currently, Player uses the system default background pixel color instead of rendering a black texture. This is a corner case, but there is some chance some game look different in this scene due to this difference. The current background color used with HideTitle is correct, so the fix should also preserve this behavior.

Test case in the title scene of:
https://github.com/EasyRPG/Player/files/3006572/midi-loop-test.zip
Online test:
https://easyrpg.org/play/master/?game=issue-834

Player screenshot:
Captura de pantalla de 2019-03-25 23-30-49

RPG_RT screenshot:
Captura de pantalla de 2019-03-25 23-30-00

Tondorian added a commit to Tondorian/Player that referenced this issue Apr 19, 2019

This commit sets the background color to black if there is no title s…
…creen available.

If parameter --hide-title is set the background color is not modified.

Fixes: EasyRPG#1728

Tondorian added a commit to Tondorian/Player that referenced this issue Apr 19, 2019

sets the background color to black if there is no title screen availa…
…ble.

If parameter --hide-title is set the background color is not modified.

Fixes: EasyRPG#1728

Tondorian added a commit to Tondorian/Player that referenced this issue Apr 19, 2019

sets the background color to black if there is no title screen availa…
…ble.

If parameter --hide-title is set the background color is not modified.

Fixes: EasyRPG#1728

@fdelapena fdelapena added this to the 0.6.1 milestone Apr 19, 2019

Tondorian added a commit to Tondorian/Player that referenced this issue Apr 19, 2019

sets the background color to black if there is no title screen availa…
…ble.

If parameter --hide-title is set the background color is not modified.

Fixes: EasyRPG#1728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.