Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yume2kki: 3 GB memory usage in the Depths #1755

Closed
Ghabry opened this issue Apr 26, 2019 · 2 comments

Comments

@Ghabry
Copy link
Member

commented Apr 26, 2019

Start from map 559 and move through the door.

The problem is the Screen tone blit affecting 1000 events.

I already work on a patch for this, found multiple memory wastes in the Sprite class (not leaks, they are all deleted when the map changes).

@Ghabry Ghabry added the Bitmaps label Apr 26, 2019

@Ghabry Ghabry added this to the 0.6.1 milestone Apr 26, 2019

@Ghabry Ghabry self-assigned this Apr 26, 2019

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 6, 2019

Support caching of Sprite effects.
Reduces the memory usage significantly when a screen flash or tone is applied because this created new bitmaps for each event before.

Fix EasyRPG#1755
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

I tried this map and it's unusably slow on my beefy desktop on linux. I've got an Intel Xeon E3 from 2017 and an Nvidia GTX 1080 and I get 0 fps!

I haven't looked carefully at your PR yet, but it seems to me the most obvious thing would be to not apply screen effects to sprites that aren't visible.

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

I haven't looked carefully at your PR yet, but it seems to me the most obvious thing would be to not apply screen effects to sprites that aren't visible.

Yes this is one of the optimizations in my PR.
The 2nd is that equal effects are shared now across the same charsets. This way the effect is only calculated once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.