Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment inflict states test cases #1770

Closed
fmatthew5876 opened this issue May 25, 2019 · 10 comments

Comments

@fmatthew5876
Copy link
Contributor

commented May 25, 2019

Test Cases 1 - Equip and remove + status counter

  1. Have an event inflict poison on an actor
  2. Save your game - status value is 1
  3. Finish a battle
  4. Save your game - status value is >= 2
  5. Equip an armor which inflicts point
  6. Save your game - status value is 1
  7. Finish a battle
  8. Save your game - status value is >= 2
  9. Unequip the armor
  10. Poison is removed
  11. Save your game - status value is 0

Conclusions

  • Equipping armor always resets status counter to 1
  • Unequipping always removes the state, giving free infinite healing of states!
  • State counter still grows during battle turns
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 2 - State priorities

Create poison with priority 50, stun with priority 30, both persisting after battle

  1. Armor removes states
  • Have an event inflict stun
  • Save your game -> stun status is 1
  • Equip an armor which inflicts poison
  • Save game -> Poison status is 1, stun is 0
  • Remove poison armor
  • Save game -> all states gone
  1. Armor has low state, event / armor tries to remove
  • Equip armor inflict stun
  • Save game -> stun status is 1
  • Have an event inflict poison
  • Save game -> stun and poison status is 1
  • Equip poison armor
  • Save game -> stun and poison status is 1

Conclusions

  • States added by equipment are never removed due to priorities.
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 3 - Battle States on the map

Setup confuse as battle only state

  1. Battle States by equip
  • Equip armor that inflicts confuse
  • Save game -> No states
  • Start a battle - actor is confused
  • Actor attacks self -> stays confused
  • Finish the battle
  • Save game -> no states
  1. Battle states by event
  • Have event add confuse
  • Save game -> actor is confused
  • Start battle - actor is confused
  • Finish Battle
  • Save game -> no states

Conclusion

  • Equipment that inflicts states will not inflict battle states on the map
  • Equipment battle states cleared after battle end
  • Events can inflict battle states - they cleared after battle ends
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 4 - Healing Items and Skills

  1. Items from Map
  • Equip poison armor
  • Try to use an antidote
  • Menu doesn't allow usage
  1. Skills from Map
  • Equip poison armor
  • Try to use a skill which does not except cure poison
  • Skill is used, sound effect, mp consumed, but poison not healed
  1. Items from Battle
  • Equip Poison Armor
  • Use an antitode on actor with poison armor
  • Nothing happens
  • Use an antidote on different actor without poison
  • Nothing happens
  1. Skills from Battle
  • Equip Poison Armor
  • Use heal poison on actor with poison armor
  • Skill appears successful, but nothing happens
  • Use heal poison on different actor without poison
  • Skill misses

Conclusions:

When states equipment is equipped:

  • Items are not usable on the map
  • Items do nothing in battle
  • Skills are usable on the map, and do nothing
  • Skills in battle appear to succeed, but nothing happens
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 5 - events healing states

  1. Events heal states
  • Equip poison armor
  • Have event heal poison
  • Poison still inflicted
  1. Events heal battle states
  • Have event inflict confuse
  • Actor is confused
  • Equip confuse armor
  • Actor is still confused
  • Have event heal confuse
  • Confuse is removed, despite having the armor equipped
  1. HealAll
  • Have event inflict confuse
  • Equip confuse and poison armor
  • Have event do RecoverAll: EntireParty
  • Confuse and poison still inflicted!
  1. Rest at inn
  • Have event inflict confuse
  • Equip confuse and poison armor
  • Have event rest at inn
  • Confuse and poison still inflicted!

Conclusions:

  • HealAll and Inn never remove equip states
  • RemoveState command will remove battle equip states on the map!
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 6 - Death

  1. Death Armor
  • Equip death armor
  • Actor is dead
  • Unequip death armor
  • Actor is revived
  1. Multiple states
  • Equip death armor
  • Equip poison armor
  • Save game -> Both death and poison states are 1
  • Walk around the map
  • Screen flashes red from poison effect on dead actor ❗️
  • Remove death armor
  • Actor is poisoned
  1. Multiple states again
  • Equip poison armor
  • Equip death armor
  • Save game -> Both death and poison states are 1
  • Walk around the map
  • Screen flashes red from poison effect on dead actor ❗️
  • Remove death armor
  • Actor is poisoned
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 7 - Equip menu

  1. Poison
  • Have an event add poison
  • Equip poison armor
  • remove poison armor without leaving equip menu
  • Poison is healed
  1. Death
  • Equip death armor
  • Remove death armor without leaving equip menu
  • Actors hp is now 1, showing that they died and then revivied
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 8 - States that halve/ double stats

  1. Half
  • Go to to equipment
  • Select an armor that inflicts state which halves stats
  • Equip arrows reflect nothing
  • Equip the armor
  • Stats on the left immediately go to half
  1. Double
  • Same as half case
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Test Cases 9 - Curse state

  1. Curse
  • Equip an armor which inflicts a state with "fixed equipment"
  • Right after equipped, unable to change equipment.
@Ghabry

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Test case 8 is fixed in my PR btw

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Test Cases 10 - Full Recovery

  1. Full Recover
  • Equip an armor which inflicts a battle state such as confuse.
  • Player is not confused
  • Have an event do full recover
  • Player is confused ❗️
  1. Inn
  • Equip an armor which inflicts a battle state such as confuse.
  • Player is not confused
  • Rest at the Inn
  • Player is confused ❗️

Conclusions

Full Recover and resting at the inn resets all equipment states, even battle ones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.