Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2k - Phantasia Gaiden issues with dual-wielding #1789

Closed
NovemberJoy opened this issue May 31, 2019 · 3 comments

Comments

@NovemberJoy
Copy link

commented May 31, 2019

Name of the game: Phantasia Gaiden

Download: Download from rpgmaker.net

Player platform: Windows 10 Home 1713

Describe the issue in detail and how to reproduce it:
Load the provided savefile and check equipment of Wataru. He's supposed to be able to equip two weapons, but something stops him from being able to do so. Loading the game in RPG_RT causes his dual wielding to function perfectly again even after saving in EasyRPG.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

I've uploaded the savegame directly to github for posterity. In the future, please upload a zip here as external hosting can disapear in the future.

Save02.zip

@NovemberJoy
Did you create this savegame from RPG_RT or Player?

The SaveActor::two_weapon chunk is missing from this save game. It looks like Player is reacting to its default value of 0, while RPG_RT is ignoring it entirely.

In rm2k, two_weapon, lock_equipment, auto_battle, and super_guard can never be changed. In rm2k3 they can only be changed when you change class.

So maybe these are all 2k3 specific SaveActor chunks which are never written or read by rm2k?

Or maybe a missing chunk defaults to whatever the Actor's default value is? Instead of 1 or 0?

Needs further investigation, but this is a great bug.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Test Cases 1 - Create actors

Create an actor with 2 weapons, lock equipment, auto battle, and super guard

  1. Create this actor in rm2k and save your game.

All LSD chunks missing

  1. Create this actor in rm2k3 and save your game

All LSD chunks set to 1

@fdelapena fdelapena added the Battle label Jun 1, 2019

@NovemberJoy

This comment has been minimized.

Copy link
Author

commented Jun 1, 2019

Save03.zip
Here's a save file made from a fresh start in EasyRPG. Dual-wielding functions.
easyrpg_log.txt
Log file after a fresh start, loading and saving in RPG_RT, and loading in EasyRPG. Ability to wield two weapons was lost in EasyRPG after saving in RPG_RT.

@fdelapena fdelapena added the Savegames label Jun 1, 2019

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 4, 2019

Fix LSD SaveActor flags in rm2k
* RM2k ignores these flags, so always reset them when loading
  saved games.
* Don't write these flags in rm2k mode.

Fix: EasyRPG#1789

@fdelapena fdelapena added this to the 0.6.1 milestone Jun 4, 2019

@Ghabry Ghabry reopened this Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.