Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aëdemphia: Image BMP needs support for BITMAPCOREHEADER #2016

Closed
Ghabry opened this issue Dec 26, 2019 · 1 comment
Closed

Aëdemphia: Image BMP needs support for BITMAPCOREHEADER #2016

Ghabry opened this issue Dec 26, 2019 · 1 comment

Comments

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Dec 26, 2019

Name of the game: Aëdemphia

Attach files (as a .zip archive or link them)

Problematic bitmap:
continentest.zip

Describe the issue in detail and how to reproduce it:

This happens on the world map but the real issue is our bitmap reader (image_bmp).

  1. The size of the DIP header at offset 0Eh should be checked. We only support the Win32 BITMAPINFOHEADER which has a size of 40d but there are others
  2. Here the size is 12d, which means it is a BITMAPCOREHEADER: https://docs.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-bitmapcoreheader
@Ghabry Ghabry added the Bitmaps label Dec 26, 2019
@carstene1ns

This comment has been minimized.

Copy link
Member

@carstene1ns carstene1ns commented Dec 27, 2019

Ok. So these really exist in the wild. 🎱
(Good thing this game is not big already. Might bloat this up with some bitmaps)

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jan 4, 2020
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jan 4, 2020
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jan 4, 2020
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jan 4, 2020
@fdelapena fdelapena added this to the 0.6.2 milestone Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.