Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo changes the Tone of MIDI songs #2029

Closed
Br4ssman opened this issue Jan 4, 2020 · 4 comments · Fixed by #2250
Closed

Tempo changes the Tone of MIDI songs #2029

Br4ssman opened this issue Jan 4, 2020 · 4 comments · Fixed by #2250

Comments

@Br4ssman
Copy link

Br4ssman commented Jan 4, 2020

Name of the game: Super Crystal Hunter

Player platform: Win 10 x64

Describe the issue in detail and how to reproduce it:

Play a MIDI modifying the Tempo.
In RPG_RT, Tempo will change the speed of a song (if it is a MIDI file, if it is MP3 will change speed and Tone), but in Player change the speed and tone, like MP3 files.

@elsemieni
Copy link
Member

This is only in fluidsynth-based builds (not nightly/jenkins builds), since tempo changes fluidsynth output (a stream). I assume this will not happen in FMMIDI/WildMIDI (however, instrument patches will be affected to this?)

@Ghabry
Copy link
Member

Ghabry commented Jun 15, 2020

WildMidi does not support tempo changes. It will always go through our resampler.

FmMidi and Fluidsynth work by making the time run faster. So this should sound similar to harmony? Needs a test when this is merged.

@fdelapena
Copy link
Contributor

fdelapena commented Jun 15, 2020

So this should sound similar to harmony?

Yes, there is no pitch change in RPG_RT MIDIs,

@Ghabry
Copy link
Member

Ghabry commented Aug 26, 2020

Note that this is only fixed for Fluidsynth, FmMidi and any new Midi sequencer libraries (if contributed).

It is not fixed for WildMidi and is unlikely that it ever will be.

For WildMidi this would need a resampling that increases the speed while keeping the pitch (no idea how this is called, the Youtube playspeed feature and my Podcast app do this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

6 participants