Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend of Tank: Endless attack when fighting "Battleship Mikasa" (戦艦三笠) #2154

Closed
Ghabry opened this issue Apr 14, 2020 · 3 comments
Closed

Comments

@Ghabry
Copy link
Member

Ghabry commented Apr 14, 2020

Name of the game:

Legend of Tank
https://www.freem.ne.jp/win/game/2356

Attach files (as a .zip archive or link them)

LegendOfTank_Save03.zip

Describe the issue in detail and how to reproduce it:

Load the save, talk to Olaf (the one in the middle).

Fast forward through the battle, after a while you will encounter an infinite attack loop.
Such loops can also happen in normal gameplay: When all actors are unable to move and don't recover.

@Ghabry
Copy link
Member Author

Ghabry commented Apr 15, 2020

The execution order is correct but the time of the movement check is wrong:

Enemy attacks (Enables Switch 100)
Page 4 executes -> Entire Party No Move
Page 2 executes
Page 2 executes
Enemy attacks
Page 4 executes
Page 2 executes
Enemy attacks
Page 4 executes
Page 2 executes
Page 3 executes -> Party can move
Turn ends in RPG_RT, but not in Player (Player runs "Page 4")

@fmatthew5876
Copy link
Contributor

I can't reproduce this anymore in master.

I talk to the pirate guy in the middle and it starts a sea battle with a ship. I tried several times and it never gets stuck.

I do remember trying this a long time ago and getting the hang. So maybe something fixed it?

@fmatthew5876 fmatthew5876 added the Needs feedback Waiting for the issue author to give further information. label Oct 17, 2020
@Ghabry
Copy link
Member Author

Ghabry commented Oct 17, 2020

Was curious here, so made a bisect. This was fixed by @rueter37 in 4405295

@Ghabry Ghabry closed this as completed Oct 17, 2020
@Ghabry Ghabry added this to the 0.6.3 milestone Oct 17, 2020
@Ghabry Ghabry removed the Needs feedback Waiting for the issue author to give further information. label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants