Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player variance calculation for damage is not accurate #2157

Closed
4 tasks done
fmatthew5876 opened this issue Apr 15, 2020 · 0 comments · Fixed by #2158
Closed
4 tasks done

Player variance calculation for damage is not accurate #2157

fmatthew5876 opened this issue Apr 15, 2020 · 0 comments · Fixed by #2158

Comments

@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Apr 15, 2020

The way RPG_RT computes variance is slightly different than how we do it. RPG_RT's algorithm provides greater resolution in values for high numbers. For low numbers, it always at least adds 1, which can make a significant difference in early game.

The algorithm should be

if (var > 0) {
  adj = max(1, 4 * var / 10);
  effect += randInclusive(0, adj) - adj / 2
}

This includes:

  • Normal Attack
  • Skill usage
  • Monster Self Destruct
  • Event Command Simulated Attack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants