Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: Player macOS master branch build job fails due to linking issues #2303

Closed
fdelapena opened this issue Aug 25, 2020 · 2 comments
Closed

Comments

@fdelapena
Copy link
Contributor

fdelapena commented Aug 25, 2020

There's something odd in the Jenkins build job. The macOS pull request builder works without issues. Already tried to clean liblcf and Player workspace, but the issue still persists. @tyrone-sudeium mentioned it builds flawlessly on his Mac, too.

@fdelapena fdelapena added this to the 0.6.3 milestone Aug 25, 2020
@Ghabry
Copy link
Member

Ghabry commented Aug 25, 2020

The linker error is for the unit tests. I added a workaround in #2232 but it only works for debug builds 🙈

@Ghabry
Copy link
Member

Ghabry commented Aug 27, 2020

On emscripten you get the same linker error in a release build:

error: undefined symbol: 
_ZNSt3__2lsIcNS_11char_traitsIcEENS_9allocatorIcEEEERNS_13basic_ostreamIT_T0_EES9_RKNS_12basic_stringIS6_S7_T1_EE
(referenced by top-level compiled C/C++ code)

Ghabry added a commit that referenced this issue Sep 7, 2020
…nclude <ostream>" everywhere where std::string is used in << (REQUIRE)

see https://bugs.llvm.org/show_bug.cgi?id=41563

Helps emscripten and macOS

Fix #2303
Ghabry added a commit that referenced this issue Sep 8, 2020
…nclude <ostream>" everywhere where std::string is used in << (REQUIRE)

see https://bugs.llvm.org/show_bug.cgi?id=41563

Helps emscripten and macOS

Fix #2303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants