Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of custom EasyRPG terms #2362

Closed
15 tasks done
fmatthew5876 opened this issue Sep 26, 2020 · 14 comments · Fixed by #2502
Closed
15 tasks done

List of custom EasyRPG terms #2362

fmatthew5876 opened this issue Sep 26, 2020 · 14 comments · Fixed by #2502
Labels
Enhancement Feature Request Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Milestone

Comments

@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Sep 26, 2020

This issue is to create a list of all the hard coded strings in RPG_RT that we would like to add as customizable Terms as an easyrpg extension. The rule can follow SaveActor::name, in that the string defaults to \x1 which means use the RPG_RT compatible default value.

We could also extend the RPG_RT defaults to use "advocate" or "2k3e" translations, depending on the engine version.

Menu Scene (#2473)

  • Item number separator
  • Skill cost separator
  • Equipment arrow
  • Status Screen Name
  • Status Screen Class
  • Status Screen Title
  • Status Screen Condition
  • Status Screen Frnt
  • Status Screen Back

Battle Scene (#2502)

  • 2k3 battle monster double attack notification
  • 2k3 battle monster defend notification
  • 2k3 battle monster observe notification
  • 2k3 battle monster charge up notification
  • 2k3 battle monster self-destruct notification
  • 2k3 message for back and pincer attack (default is no message)
@fmatthew5876 fmatthew5876 added UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design Enhancement Feature Request labels Sep 26, 2020
@Ghabry
Copy link
Member

Ghabry commented Oct 1, 2020

The 2k3 battle notification for skill (currently is the skill name) should be also customizable (with placeholder support as in 2k)

@Tayruu
Copy link

Tayruu commented Oct 2, 2020

I've edited things like these myself in my RPG_RT, so the ability to set them somehow without compiling my own Player would be neat. (Though I have some functions I'll need to custom compile anyway.)

Just missing the "-----/-----" of max EXP.

@Ghabry
Copy link
Member

Ghabry commented Oct 2, 2020

This --------/------- vs EXP/-------- could be also a configuration. But more a flag than a term.


Or maybe we should just add the "Scene Push" event command I suggested, reimplement the entire Menu scene in RPG Maker Event script and then you can alter stuff by modifying event code ;))).

@ghost
Copy link

ghost commented Mar 3, 2021

The "Confirm" and "Redo" commands in the party order scene are hard coded as well.

@Ghabry
Copy link
Member

Ghabry commented Mar 3, 2021

@rueter37
I just saw this commit in liblcf: https://github.com/rueter37/liblcf/commit/cf01c364b07c974aa0fb3a0a13cbd69345202386
Can you PR this commit?
Looks like a good start for this feature.

@ghost
Copy link

ghost commented Mar 3, 2021

@Ghabry I have opened a PR with the commit you mentioned now in liblcf.

@ghost
Copy link

ghost commented Mar 6, 2021

I think the ------/------ vs EXP/------ on the last level should be a user preference. But my proposal here requires #2035 to be merged in.

@ghost
Copy link

ghost commented Mar 9, 2021

Don't get fooled by the text which says that my PR #2473 will close this issue. It is only a partial fix.

@Ghabry
Copy link
Member

Ghabry commented Mar 9, 2021

You must reword it to prevent an autoclose.
We usually use e.g. Related: #1234

@ghost
Copy link

ghost commented Mar 9, 2021

Thanks for the pointer how to disable the autoclose! 👍

@ghost
Copy link

ghost commented Mar 23, 2021

Since #2399 is merged in now we can take on the battle scene terms now. You can check out this liblcf and player branch which has got everything needed for battle scene terms and customizable battle notifications for skills in RPG Maker 2003 battles.

@Ghabry
Copy link
Member

Ghabry commented Mar 23, 2021

I see that you also added Placeholder support?

@ghost
Copy link

ghost commented Mar 23, 2021

Yes, to make the battle notifications for skills more useful (see your comment).

@ghost
Copy link

ghost commented Mar 31, 2021

Added a liblcf PR and Player PR now which should implement the remaining features to close this issue.

@Ghabry Ghabry added this to the 0.6.3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature Request Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Development

Successfully merging a pull request may close this issue.

4 participants