Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vampires Dawn II: No visual indication when using a healing spell #2479

Closed
Ghabry opened this issue Mar 15, 2021 · 4 comments · Fixed by #2505
Closed

Vampires Dawn II: No visual indication when using a healing spell #2479

Ghabry opened this issue Mar 15, 2021 · 4 comments · Fixed by #2505

Comments

@Ghabry
Copy link
Member

Ghabry commented Mar 15, 2021

In VD2 the actors do not flash when selecting a target for Skill "Schwache Heilung" making it almost impossible to target the correct one.

Save05.zip
Fight the slime to the left of you. NOTE: The scrolling map is because this is a very old EasyRPG Player save (is fixed by changing the map once).

@rueter37

@Ghabry Ghabry added the Battle label Mar 15, 2021
@ghost
Copy link

ghost commented Mar 15, 2021

@Ghabry check out this branch: https://github.com/rueter37/player/tree/battleanimation-sprites. I'm going to PR this one after #2399 has been merged. This is the successor of #2328 and plans on fixing issues in relation to battle animation sprites. This covers this issue as well.

@Ghabry Ghabry assigned ghost Mar 15, 2021
@Ghabry
Copy link
Member Author

Ghabry commented Mar 15, 2021

btw if you want you can already open your branch as a PR (set it to Draft when opening it). Then we can already start reviewing it.

That it is based on fmatthews is no problem. When that is merged you simply rebase and then yours gets the turn.

@ghost
Copy link

ghost commented Mar 15, 2021

I have added a draft PR now (#2482). Edit: This issue is no longer handled by the mentioned PR, as I had to remove the flash changes there because they were broken.

@ghost
Copy link

ghost commented Apr 2, 2021

I have added a PR now (#2505) which should hopefully fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants