Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death with "Ends after Battle" is removed but HP stays at 0 #2521

Closed
Ghabry opened this issue May 5, 2021 · 1 comment · Fixed by #2529
Closed

Death with "Ends after Battle" is removed but HP stays at 0 #2521

Ghabry opened this issue May 5, 2021 · 1 comment · Fixed by #2529

Comments

@Ghabry
Copy link
Member

Ghabry commented May 5, 2021

Name of the game:

さいはてHOSPITAL

Describe the issue in detail and how to reproduce it:

After a certain battle the game gives a game over. The battle is scripted, you can only lose. There is a "On Lose" handler, so the game continues on the map.

The problem is here that the game has "Ends after Battle" configured for the "Death" state. The state itself is removed but the HP stay at 0. They must be increased to 1.

Not sure where to put the fix for this, otherwise would have opened a PR already.


Reported via Mail. Thanks :)

@Ghabry Ghabry added the Battle label May 5, 2021
@Ghabry Ghabry added this to the 0.7.0 milestone May 5, 2021
@Ghabry
Copy link
Member Author

Ghabry commented May 14, 2021

This appears to be one of the most serious bugs still remaining in player. Lots of Japanese Twitter discussions about it 🤔

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 14, 2021
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 15, 2021
All state removal goes now through the same logic.

Fix EasyRPG#2521
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 15, 2021
All state removal goes now through the same logic.

Fix EasyRPG#2521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant